From 8f73e10f6e2b05c98cf43697c567fea05dda5454 Mon Sep 17 00:00:00 2001 From: topepo Date: Fri, 1 Aug 2025 16:19:55 -0400 Subject: [PATCH 1/3] Closes #248 --- tests/testthat/test-stacks-columns.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-stacks-columns.R b/tests/testthat/test-stacks-columns.R index f6ea99de..64236498 100644 --- a/tests/testthat/test-stacks-columns.R +++ b/tests/testthat/test-stacks-columns.R @@ -40,7 +40,7 @@ test_that("stacks can accommodate outcome levels that are not valid colnames", { ) expect_true(inherits(data_st, "data_stack")) - expect_true(".pred_Adelie.1_tuned_1_1" %in% colnames(data_st)) + expect_true(".pred_Adelie.1_tunedpre0_mod2_post0" %in% colnames(data_st)) # glmnet will likely present warnings suppressMessages( From 7575f59ad23f8de3a51af82c76abd8716e98ec79 Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Wed, 13 Aug 2025 16:24:13 -0700 Subject: [PATCH 2/3] add missing skip_if_not_installed("tune", "1.3.0.9006") --- tests/testthat/test-stacks-columns.R | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testthat/test-stacks-columns.R b/tests/testthat/test-stacks-columns.R index 64236498..5f3f68e7 100644 --- a/tests/testthat/test-stacks-columns.R +++ b/tests/testthat/test-stacks-columns.R @@ -16,6 +16,7 @@ library(dplyr) test_that("stacks can accommodate outcome levels that are not valid colnames", { # skip on pre-0.2.4 skip_if(utils::packageVersion("stacks") < "0.2.3.9001") + skip_if_not_installed("tune", "1.3.0.9006") data("penguins") From 61c62ec7e8f430941e3b6218e355f5013751c76b Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Wed, 13 Aug 2025 17:24:43 -0700 Subject: [PATCH 3/3] update sep argument --- tests/testthat/test-stacks-tuning.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-stacks-tuning.R b/tests/testthat/test-stacks-tuning.R index 0b39dbf4..3e6890ba 100644 --- a/tests/testthat/test-stacks-tuning.R +++ b/tests/testthat/test-stacks-tuning.R @@ -190,7 +190,7 @@ test_that("stacking with finetune works (anova)", { dplyr::rowwise() %>% dplyr::mutate( .config = gsub("Preprocessor|Model", "", .config), - col_name = paste(wflow_id, .config, sep = "_") + col_name = paste(wflow_id, .config, sep = "") ) %>% pull(col_name)