-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Review supersession #6389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Let's create a list. It's open for additional suggestions. Already superseded:
Considered for supersession:
|
Behaviour to supersede:
TODO: review arguments specifically. |
Could |
The problem with |
Also, the new approach to setting colour palettes does not do entirely what the old options approach does, as you cannot set the NA value with the new approach. Great to start the process of getting rid of the redundant functions! |
Not everyone needs to learn ggplot2 to an advanced level, @teunbrand |
I think discoverability and ability to memorize patterns are both very important for regular users. I don't even know what In general, I have found that while it's great that there are all these nifty tricks that people can in principle use to get advanced outputs in an elegant way, in practice very few people have the mental capacity to memorize all these tricks and use them in the appropriate circumstances. Not sure how useful this is in the present context, just pointing this out as something to keep in mind. |
Separate from this PR, my idea is that there will be limit helper functions in scales, e.g. r-lib/scales#490. Which has the benefits of not being circuitous and being discoverable. |
I was debating whether I should bring up the scales package as an example of a repository of great helper functions that can in principle solve all sorts of issues I have and that I can never remember how to use... ;-) |
Oh, those new scales helpers are really nice! +1 for UK spelling While you're looking at supercession ideas, I just remembered this interesting post from a year ago on mastodon re xlim/ylim (& lims by association) |
@davidhodge931 We're completely off-topic now, but |
just to fully agree with Clause's comment |
Let's be clear on what superseding means. It means that there is a new and (in our opinion) better way of doing this. Superseded behaviour is not going away in the way deprecated functionality does. So "the old guard" can continue to do what they've always done. But, if you are a new user you will gently be steered towards the new way of doing things. |
Hacks are not necessarily easier to learn than the right way of doing it. It just so happen that these hacks have been internalised by some people who will then feel resistance towards learning a different way. This is not pointing fingers. It is totally understandable. But it is also a poor argument for not superseding a function |
It'd be helpful to review which functions have preferred alternatives and mark them as superseded.
As an example,
coord_polar()
can be replaced withcoord_radial()
, but isn't documented like that.I'd expect some helper functions to be functionally superseded as well.
The text was updated successfully, but these errors were encountered: