Consistency: parameters should match function name `have_auxiliary_node_vars` #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

benegee opened this issue May 7, 2025 · 0 comments · May be fixed by #2400

Assignees

Labels

Contributor

benegee commented May 7, 2025

I would actually prefer to change nonconservative_terms to have_nonconservative_terms but that is a separate issue).

Originally posted by @tristanmontoya in #2348 (comment)

The text was updated successfully, but these errors were encountered:

benegee changed the title Consistency: parameters should match function name have_auxiliary_node_vars. If you want to be consistent with nonconservative_terms, then maybe it should just be auxiliary_node_vars, but this could be confused with the actual variables rather than just a boolean (I would actually prefer to change nonconservative_terms to have_nonconservative_terms Consistency: parameters should match function name have_auxiliary_node_vars

benegee added the consistency label

benegee mentioned this issue

Add auxiliary variables #2348

Open

4 tasks

benegee self-assigned this

benegee linked a pull request

that will close this issue

Use variable name have_nonconservative_terms everywhere #2400

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment