Fix BaseModelForm, ErrorList, ErrorDict __init__(renderer=) parameter (#1690)

Adds ErrorList and ErrorDict __init__'s

Was not able to remove the __init__ from the allowlist, as there seems to be an issue with ErrorList.

Added basic ErrorDict constructor signature.

Author: GabDug

django-stubs/forms/models.pyi

@@ -81,7 +81,7 @@ class BaseModelForm(Generic[_M], BaseForm):
         empty_permitted: bool = ...,
         instance: _M | None = ...,
         use_required_attribute: bool | None = ...,
-        renderer: BaseRenderer = ...,
+        renderer: BaseRenderer | None = ...,
     ) -> None: ...
     def validate_unique(self) -> None: ...
     def save(self, commit: bool = ...) -> _M: ...

django-stubs/forms/utils.pyi

@@ -46,6 +46,7 @@ class ErrorDict(dict[str, ErrorList], RenderableErrorMixin):
     template_name_ul: str
     renderer: BaseRenderer
 
+    def __init__(self, *args: Any, renderer: BaseRenderer | None = None, **kwargs: Any): ...
     def as_data(self) -> dict[str, list[ValidationError]]: ...
     def get_json_data(self, escape_html: bool = ...) -> dict[str, Any]: ...
 
@@ -59,6 +60,7 @@ class ErrorList(UserList[ValidationError | _StrOrPromise], RenderableErrorMixin)
         self,
         initlist: ErrorList | Sequence[str | Exception] | None = ...,
         error_class: str | None = ...,
+        renderer: BaseRenderer | None = ...,
     ) -> None: ...
     def as_data(self) -> list[ValidationError]: ...
     def get_json_data(self, escape_html: bool = ...) -> list[dict[str, str]]: ...

scripts/stubtest/allowlist_todo.txt

@@ -2093,8 +2093,6 @@ django.forms.renderers.DjangoDivFormRenderer
 django.forms.renderers.EngineMixin.engine
 django.forms.renderers.Jinja2.backend
 django.forms.utils.DEFAULT_TEMPLATE_DEPRECATION_MSG
-django.forms.utils.ErrorDict.__init__
-django.forms.utils.ErrorList.__init__
 django.forms.widgets.ChoiceWidget.__deepcopy__
 django.forms.widgets.ChoiceWidget.subwidgets
 django.forms.widgets.ChoiceWidget.template_name