Skip to content

Commit e7cee55

Browse files
committed
Simplify conversion of edits.
1 parent 1909749 commit e7cee55

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/Completion.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
package org.rascalmpl.vscode.lsp.util;
2828

2929
import java.util.Collections;
30+
import java.util.HashMap;
3031
import java.util.List;
3132
import java.util.concurrent.CompletableFuture;
3233
import java.util.function.Function;
@@ -36,6 +37,7 @@
3637
import org.apache.logging.log4j.LogManager;
3738
import org.apache.logging.log4j.Logger;
3839
import org.checkerframework.checker.nullness.qual.Nullable;
40+
import org.eclipse.lsp4j.ChangeAnnotation;
3941
import org.eclipse.lsp4j.CompletionContext;
4042
import org.eclipse.lsp4j.CompletionItem;
4143
import org.eclipse.lsp4j.CompletionItemKind;
@@ -47,7 +49,6 @@
4749
import org.eclipse.lsp4j.MarkupKind;
4850
import org.eclipse.lsp4j.Position;
4951
import org.eclipse.lsp4j.Range;
50-
import org.eclipse.lsp4j.TextDocumentEdit;
5152
import org.eclipse.lsp4j.jsonrpc.messages.Either;
5253
import org.rascalmpl.values.IRascalValueFactory;
5354
import org.rascalmpl.vscode.lsp.IBaseTextDocumentService;
@@ -129,12 +130,8 @@ public List<CompletionItem> toLSP(final IBaseTextDocumentService docService, Typ
129130
.map(IString::getValue)
130131
.collect(Collectors.toList()));
131132

132-
var wsEdit = DocumentChanges.translateDocumentChanges(docService, (IList) kws.getParameter(ADDITIONAL_CHANGES));
133-
ci.setAdditionalTextEdits(wsEdit.getDocumentChanges()
134-
.stream()
135-
.map(e -> (TextDocumentEdit) e.get())
136-
.flatMap(t -> t.getEdits().stream())
137-
.collect(Collectors.toList()));
133+
var edits = DocumentChanges.translateTextEdits(docService, (IList) kws.getParameter(ADDITIONAL_CHANGES), new HashMap<String, ChangeAnnotation>());
134+
ci.setAdditionalTextEdits(edits);
138135

139136
ci.setCommand(CodeActions.constructorToCommand(dedicatedLanguageName, languageName, (IConstructor) kws.getParameter(COMMAND)));
140137

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/DocumentChanges.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public static WorkspaceEdit translateDocumentChanges(final IBaseTextDocumentServ
9797
return wsEdit;
9898
}
9999

100-
private static List<TextEdit> translateTextEdits(final IBaseTextDocumentService docService, IList edits, Map<String, ChangeAnnotation> changeAnnotations) {
100+
static List<TextEdit> translateTextEdits(final IBaseTextDocumentService docService, IList edits, Map<String, ChangeAnnotation> changeAnnotations) {
101101
return edits.stream()
102102
.map(IConstructor.class::cast)
103103
.map(c -> {

0 commit comments

Comments
 (0)