Skip to content

Commit 5cc114e

Browse files
use XMLTools to create DocumentBuilder (less redundancy)
1 parent 90e29cf commit 5cc114e

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@
2525
import java.util.List;
2626
import java.util.logging.Logger;
2727

28-
import javax.xml.XMLConstants;
2928
import javax.xml.parsers.DocumentBuilder;
30-
import javax.xml.parsers.DocumentBuilderFactory;
31-
import javax.xml.parsers.ParserConfigurationException;
3229

3330
import org.springframework.jdbc.core.CallableStatementCallback;
3431
import org.springframework.jdbc.core.JdbcTemplate;
@@ -130,9 +127,7 @@ public Void doInCallableStatement(final CallableStatement cs) throws SQLExceptio
130127
private RealtimeReporterEvent convert(final String itemType, final String text) {
131128
logger.fine(() -> "\n---- " + itemType + " ----\n" + text);
132129
try {
133-
final DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
134-
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, Boolean.TRUE);
135-
final DocumentBuilder docBuilder = factory.newDocumentBuilder();
130+
final DocumentBuilder docBuilder = xmlTools.createDocumentBuilder();
136131
final Document doc = docBuilder.parse(new InputSource(new StringReader(text)));
137132
RealtimeReporterEvent event = null;
138133
if ("pre-run".equals(itemType)) {
@@ -149,10 +144,6 @@ private RealtimeReporterEvent convert(final String itemType, final String text)
149144
event = convertToPostTestEvent(doc);
150145
}
151146
return event;
152-
} catch (ParserConfigurationException e) {
153-
final String msg = "Cannot create docBuilder for " + itemType + " with content: " + text;
154-
logger.severe(() -> msg);
155-
throw new GenericRuntimeException(msg, e);
156147
} catch (SAXException e) {
157148
final String msg = "Parse error while processing " + itemType + " with content: " + text;
158149
logger.severe(() -> msg);

0 commit comments

Comments
 (0)