@@ -94,8 +94,8 @@ public UtmIncident changeStatus(UtmIncident utmIncident) {
9494 try {
9595 log .debug ("Request to save UtmIncident : {}" , utmIncident );
9696 String oldIncident = ResolveIncidentStatus .incidentLabel (utmIncidentRepository .
97- findById (utmIncident .getId ())
98- .orElseThrow (() -> new RuntimeException ("Incident not found" )));
97+ findById (utmIncident .getId ())
98+ .orElseThrow (() -> new RuntimeException ("Incident not found" )));
9999
100100 UtmIncident incident = utmIncidentRepository .save (utmIncident );
101101 List <UtmIncidentAlert > alerts = utmIncidentAlertService .findAllByIncidentId (incident .getId ());
@@ -136,34 +136,30 @@ public UtmIncident changeStatus(UtmIncident utmIncident) {
136136 */
137137 public UtmIncident createIncident (NewIncidentDTO newIncidentDTO ) {
138138 final String ctx = CLASSNAME + ".createIncident" ;
139- try {
140- validateAlertsNotAlreadyLinked (newIncidentDTO .getAlertList (), ctx );
141139
142- UtmIncident utmIncident = new UtmIncident ();
143- utmIncident .setIncidentName (newIncidentDTO .getIncidentName ());
144- utmIncident .setIncidentDescription (newIncidentDTO .getIncidentDescription ());
145- utmIncident .setIncidentStatus (IncidentStatusEnum .OPEN );
146- Integer severity = newIncidentDTO .getAlertList ().stream ()
140+ validateAlertsNotAlreadyLinked (newIncidentDTO .getAlertList (), ctx );
141+
142+ UtmIncident utmIncident = new UtmIncident ();
143+ utmIncident .setIncidentName (newIncidentDTO .getIncidentName ());
144+ utmIncident .setIncidentDescription (newIncidentDTO .getIncidentDescription ());
145+ utmIncident .setIncidentStatus (IncidentStatusEnum .OPEN );
146+ Integer severity = newIncidentDTO .getAlertList ().stream ()
147147 .mapToInt (RelatedIncidentAlertsDTO ::getAlertSeverity ).max ().orElse (0 );
148- utmIncident .setIncidentSeverity (severity );
149- utmIncident .setIncidentAssignedTo (newIncidentDTO .getIncidentAssignedTo ());
150- utmIncident .setIncidentCreatedDate (new Date ().toInstant ());
148+ utmIncident .setIncidentSeverity (severity );
149+ utmIncident .setIncidentAssignedTo (newIncidentDTO .getIncidentAssignedTo ());
150+ utmIncident .setIncidentCreatedDate (new Date ().toInstant ());
151151
152- UtmIncident savedIncident = utmIncidentRepository .save (utmIncident );
152+ UtmIncident savedIncident = utmIncidentRepository .save (utmIncident );
153153
154- saveRelatedAlerts (newIncidentDTO .getAlertList (), savedIncident .getId ());
154+ saveRelatedAlerts (newIncidentDTO .getAlertList (), savedIncident .getId ());
155155
156- sendIncidentsEmail (newIncidentDTO .getAlertList ().stream ().map (RelatedIncidentAlertsDTO ::getAlertId ).collect (Collectors .toList ()), savedIncident );
156+ sendIncidentsEmail (newIncidentDTO .getAlertList ().stream ().map (RelatedIncidentAlertsDTO ::getAlertId ).collect (Collectors .toList ()), savedIncident );
157157
158- String historyMessage = String .format ("Incident created with %d alerts" , newIncidentDTO .getAlertList ().size ());
159- utmIncidentHistoryService .createHistory (IncidentHistoryActionEnum .INCIDENT_CREATED , savedIncident .getId (), "Incident Created" , historyMessage );
158+ String historyMessage = String .format ("Incident created with %d alerts" , newIncidentDTO .getAlertList ().size ());
159+ utmIncidentHistoryService .createHistory (IncidentHistoryActionEnum .INCIDENT_CREATED , savedIncident .getId (), "Incident Created" , historyMessage );
160+
161+ return savedIncident ;
160162
161- return savedIncident ;
162- } catch (Exception e ) {
163- String msg = ctx + ": " + e .getMessage ();
164- eventService .createEvent (msg , ApplicationEventType .ERROR );
165- throw new RuntimeException (msg );
166- }
167163 }
168164
169165 /**
@@ -174,33 +170,29 @@ public UtmIncident createIncident(NewIncidentDTO newIncidentDTO) {
174170 */
175171 public UtmIncident addAlertsIncident (@ Valid AddToIncidentDTO addToIncidentDTO ) {
176172 final String ctx = CLASSNAME + ".addAlertsIncident" ;
177- try {
178- log .debug ("Request to add alert to UtmIncident : {}" , addToIncidentDTO );
179173
180- List < RelatedIncidentAlertsDTO > alertIds = addToIncidentDTO . getAlertList ( );
174+ log . debug ( "Request to add alert to UtmIncident : {}" , addToIncidentDTO );
181175
182- String alertsIds = alertIds .stream ().map (RelatedIncidentAlertsDTO ::getAlertId ).collect (Collectors .joining ("," ));
183- Map <String , Object > extra = Map .of (
184- "alertIds" , alertsIds ,
185- "source" , "service"
186- );
187- String attemptMsg = String .format ("Attempt to add %d alerts to incident %d" , addToIncidentDTO .getAlertList ().size (), addToIncidentDTO .getIncidentId ());
188- eventService .createEvent (attemptMsg , ApplicationEventType .INCIDENT_ALERT_ADD_ATTEMPT , extra );
176+ List <RelatedIncidentAlertsDTO > alertIds = addToIncidentDTO .getAlertList ();
189177
190- validateAlertsNotAlreadyLinked (addToIncidentDTO .getAlertList (), ctx );
191- UtmIncident utmIncident = utmIncidentRepository .findById (addToIncidentDTO .getIncidentId ()).orElseThrow (() -> new RuntimeException (ctx + ": Incident not found" ));
192- saveRelatedAlerts (addToIncidentDTO .getAlertList (), utmIncident .getId ());
193- String historyMessage = String .format ("New %d alerts added to incident" , addToIncidentDTO .getAlertList ().size ());
194- utmIncidentHistoryService .createHistory (IncidentHistoryActionEnum .INCIDENT_ALERT_ADD , utmIncident .getId (), "New alerts added to incident" , historyMessage );
178+ String alertsIds = alertIds .stream ().map (RelatedIncidentAlertsDTO ::getAlertId ).collect (Collectors .joining ("," ));
179+ Map <String , Object > extra = Map .of (
180+ "alertIds" , alertsIds ,
181+ "source" , "service"
182+ );
183+ String attemptMsg = String .format ("Attempt to add %d alerts to incident %d" , addToIncidentDTO .getAlertList ().size (), addToIncidentDTO .getIncidentId ());
184+ eventService .createEvent (attemptMsg , ApplicationEventType .INCIDENT_ALERT_ADD_ATTEMPT , extra );
195185
196- eventService .createEvent (historyMessage , ApplicationEventType .INCIDENT_ALERTS_ADDED , extra );
186+ validateAlertsNotAlreadyLinked (addToIncidentDTO .getAlertList (), ctx );
187+ UtmIncident utmIncident = utmIncidentRepository .findById (addToIncidentDTO .getIncidentId ()).orElseThrow (() -> new RuntimeException (ctx + ": Incident not found" ));
188+ saveRelatedAlerts (addToIncidentDTO .getAlertList (), utmIncident .getId ());
189+ String historyMessage = String .format ("New %d alerts added to incident" , addToIncidentDTO .getAlertList ().size ());
190+ utmIncidentHistoryService .createHistory (IncidentHistoryActionEnum .INCIDENT_ALERT_ADD , utmIncident .getId (), "New alerts added to incident" , historyMessage );
191+
192+ eventService .createEvent (historyMessage , ApplicationEventType .INCIDENT_ALERTS_ADDED , extra );
193+
194+ return utmIncident ;
197195
198- return utmIncident ;
199- } catch (Exception e ) {
200- String msg = ctx + ": " + e .getMessage ();
201- eventService .createEvent (msg , ApplicationEventType .ERROR );
202- throw new RuntimeException (msg );
203- }
204196 }
205197
206198 @ Async
@@ -289,7 +281,7 @@ private void sendIncidentsEmail(List<String> alertIds, UtmIncident utmIncident)
289281 return ;
290282
291283 String [] addressToNotify = Constants .CFG .get (Constants .PROP_ALERT_ADDRESS_TO_NOTIFY_INCIDENTS )
292- .replace (" " , "" ).split ("," );
284+ .replace (" " , "" ).split ("," );
293285
294286 mailService .sendIncidentEmail (Arrays .asList (addressToNotify ), alerts , utmIncident );
295287
0 commit comments