test: replace popover IT with unit test (#7580) (#7603)

* test: replace popover IT with unit test

* move test to PopoverAutoAddTest

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>

Author: vaadin-bot

vaadin-popover-flow-parent/vaadin-popover-flow-integration-tests/pom.xml

@@ -49,11 +49,6 @@
             <groupId>com.vaadin</groupId>
             <artifactId>vaadin-dev-server</artifactId>
         </dependency>
-        <dependency>
-            <groupId>com.vaadin</groupId>
-            <artifactId>vaadin-dialog-flow</artifactId>
-            <version>${project.version}</version>
-        </dependency>
         <dependency>
             <groupId>com.vaadin</groupId>
             <artifactId>vaadin-flow-components-test-util</artifactId>

vaadin-popover-flow-parent/vaadin-popover-flow-integration-tests/src/main/java/com/vaadin/flow/component/popover/tests/PopoverView.java

@@ -15,7 +15,6 @@
  */
 package com.vaadin.flow.component.popover.tests;
 
-import com.vaadin.flow.component.dialog.Dialog;
 import com.vaadin.flow.component.html.Div;
 import com.vaadin.flow.component.html.NativeButton;
 import com.vaadin.flow.component.popover.Popover;
@@ -55,22 +54,7 @@ public PopoverView() {
                 event -> popover.setCloseOnOutsideClick(false));
         disableCloseOnOutsideClick.setId("disable-close-on-outside-click");
 
-        NativeButton openDialog = new NativeButton("Open dialog and set target",
-                event -> {
-                    var dialog = new Dialog();
-                    var close = new NativeButton("Close", e -> dialog.close());
-                    close.setId("close-dialog");
-                    dialog.add(close);
-                    dialog.open();
-                    popover.setTarget(target);
-                });
-        openDialog.setId("open-dialog");
-
-        NativeButton removePopover = new NativeButton("Remove popover",
-                event -> remove(popover));
-        removePopover.setId("remove-popover");
-
         add(popover, clearTarget, detachTarget, attachTarget, disableCloseOnEsc,
-                disableCloseOnOutsideClick, removePopover, openDialog, target);
+                disableCloseOnOutsideClick, target);
     }
 }

vaadin-popover-flow-parent/vaadin-popover-flow-integration-tests/src/test/java/com/vaadin/flow/component/popover/tests/PopoverIT.java

@@ -135,22 +135,6 @@ public void disableCloseOnEsc_pressEsc_popoverDoesNotClose() {
         Assert.assertTrue(popover.isOpen());
     }
 
-    @Test
-    public void openDialogAndSetTarget_closeDialog_popoverOpens() {
-        // Clear the target and remove the popover first to ensure the popover
-        // is auto-added when the dialog opens
-        clickElementWithJs("clear-target");
-        clickElementWithJs("remove-popover");
-
-        clickElementWithJs("open-dialog");
-        clickElementWithJs("close-dialog");
-
-        waitForElementNotPresent(By.tagName("vaadin-dialog-overlay"));
-
-        clickTarget();
-        checkPopoverIsOpened();
-    }
-
     private void clickTarget() {
         clickElementWithJs("popover-target");
     }

vaadin-popover-flow-parent/vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverAutoAddTest.java

@@ -153,6 +153,20 @@ public void setTarget_changeUI_autoAdded() {
         Assert.assertEquals(ui.getElement(), popover.getElement().getParent());
     }
 
+    @Test
+    public void setTarget_openModal_popoverIsAttachedToUi() {
+        Div target = new Div();
+        Popover popover = new Popover();
+        popover.setTarget(target);
+        ui.add(target);
+
+        Div modalElement = new Div();
+        ui.setChildComponentModal(modalElement, true);
+        fakeClientResponse();
+
+        Assert.assertEquals(ui, popover.getParent().orElseThrow());
+    }
+
     private void fakeClientResponse() {
         ui.getInternals().getStateTree().runExecutionsBeforeClientResponse();
         ui.getInternals().getStateTree().collectChanges(ignore -> {