Skip to content

Commit f09a804

Browse files
authored
refactor!: remove deprecated HasClientValidation, ClientValidatedEvent, ClientValidationUtil (#7583)
* refactor!: remove HasClientValidation and ClientValidatedEvent * remove ClientValidationUtil
1 parent 728dc97 commit f09a804

File tree

12 files changed

+12
-227
lines changed
  • vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox
  • vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox
  • vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker
  • vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/main/java/com/vaadin/flow/component/datetimepicker
  • vaadin-flow-components-shared-parent
  • vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton
  • vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select
  • vaadin-text-field-flow-parent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield
  • vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker

12 files changed

+12
-227
lines changed

vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/Checkbox.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import com.vaadin.flow.component.dependency.JsModule;
3232
import com.vaadin.flow.component.dependency.NpmPackage;
3333
import com.vaadin.flow.component.html.NativeLabel;
34-
import com.vaadin.flow.component.shared.HasClientValidation;
3534
import com.vaadin.flow.component.shared.HasValidationProperties;
3635
import com.vaadin.flow.component.shared.InputField;
3736
import com.vaadin.flow.component.shared.ValidationUtil;
@@ -82,7 +81,7 @@
8281
@JsModule("@vaadin/checkbox/src/vaadin-checkbox.js")
8382
public class Checkbox extends AbstractSinglePropertyField<Checkbox, Boolean>
8483
implements ClickNotifier<Checkbox>, Focusable<Checkbox>, HasAriaLabel,
85-
HasClientValidation, HasValidationProperties, HasValidator<Boolean>,
84+
HasValidationProperties, HasValidator<Boolean>,
8685
InputField<AbstractField.ComponentValueChangeEvent<Checkbox, Boolean>, Boolean> {
8786

8887
private final NativeLabel labelElement;

vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/CheckboxGroup.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import com.vaadin.flow.component.checkbox.dataview.CheckboxGroupListDataView;
4242
import com.vaadin.flow.component.dependency.JsModule;
4343
import com.vaadin.flow.component.dependency.NpmPackage;
44-
import com.vaadin.flow.component.shared.HasClientValidation;
4544
import com.vaadin.flow.component.shared.HasThemeVariant;
4645
import com.vaadin.flow.component.shared.HasValidationProperties;
4746
import com.vaadin.flow.component.shared.InputField;
@@ -116,8 +115,8 @@
116115
@JsModule("@vaadin/checkbox-group/src/vaadin-checkbox-group.js")
117116
public class CheckboxGroup<T>
118117
extends AbstractSinglePropertyField<CheckboxGroup<T>, Set<T>>
119-
implements HasAriaLabel, HasClientValidation,
120-
HasDataView<T, Void, CheckboxGroupDataView<T>>, HasItemComponents<T>,
118+
implements HasAriaLabel, HasDataView<T, Void, CheckboxGroupDataView<T>>,
119+
HasItemComponents<T>,
121120
InputField<AbstractField.ComponentValueChangeEvent<CheckboxGroup<T>, Set<T>>, Set<T>>,
122121
HasListDataView<T, CheckboxGroupListDataView<T>>,
123122
HasThemeVariant<CheckboxGroupVariant>, HasValidationProperties,

vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBoxBase.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import com.vaadin.flow.component.shared.HasAllowedCharPattern;
5050
import com.vaadin.flow.component.shared.HasAutoOpen;
5151
import com.vaadin.flow.component.shared.HasClearButton;
52-
import com.vaadin.flow.component.shared.HasClientValidation;
5352
import com.vaadin.flow.component.shared.HasOverlayClassName;
5453
import com.vaadin.flow.component.shared.HasValidationProperties;
5554
import com.vaadin.flow.component.shared.InputField;
@@ -94,7 +93,7 @@
9493
public abstract class ComboBoxBase<TComponent extends ComboBoxBase<TComponent, TItem, TValue>, TItem, TValue>
9594
extends AbstractSinglePropertyField<TComponent, TValue>
9695
implements Focusable<TComponent>, HasAllowedCharPattern, HasAriaLabel,
97-
HasAutoOpen, HasClearButton, HasClientValidation, HasOverlayClassName,
96+
HasAutoOpen, HasClearButton, HasOverlayClassName,
9897
HasDataView<TItem, String, ComboBoxDataView<TItem>>,
9998
InputField<AbstractField.ComponentValueChangeEvent<TComponent, TValue>, TValue>,
10099
HasLazyDataView<TItem, String, ComboBoxLazyDataView<TItem>>,

vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import com.vaadin.flow.component.shared.HasAllowedCharPattern;
4848
import com.vaadin.flow.component.shared.HasAutoOpen;
4949
import com.vaadin.flow.component.shared.HasClearButton;
50-
import com.vaadin.flow.component.shared.HasClientValidation;
5150
import com.vaadin.flow.component.shared.HasOverlayClassName;
5251
import com.vaadin.flow.component.shared.HasPrefix;
5352
import com.vaadin.flow.component.shared.HasThemeVariant;
@@ -134,7 +133,7 @@
134133
public class DatePicker
135134
extends AbstractSinglePropertyField<DatePicker, LocalDate>
136135
implements Focusable<DatePicker>, HasAllowedCharPattern, HasAriaLabel,
137-
HasAutoOpen, HasClearButton, HasClientValidation,
136+
HasAutoOpen, HasClearButton,
138137
InputField<AbstractField.ComponentValueChangeEvent<DatePicker, LocalDate>, LocalDate>,
139138
HasOverlayClassName, HasPrefix, HasThemeVariant<DatePickerVariant>,
140139
HasValidationProperties, HasValidator<LocalDate>, HasPlaceholder {

vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/main/java/com/vaadin/flow/component/datetimepicker/DateTimePicker.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import com.vaadin.flow.component.dependency.JsModule;
3535
import com.vaadin.flow.component.dependency.NpmPackage;
3636
import com.vaadin.flow.component.shared.HasAutoOpen;
37-
import com.vaadin.flow.component.shared.HasClientValidation;
3837
import com.vaadin.flow.component.shared.HasOverlayClassName;
3938
import com.vaadin.flow.component.shared.HasThemeVariant;
4039
import com.vaadin.flow.component.shared.HasValidationProperties;
@@ -94,7 +93,7 @@ boolean isPickerInputUnparsable() {
9493
@JsModule("@vaadin/date-time-picker/src/vaadin-date-time-picker.js")
9594
public class DateTimePicker
9695
extends AbstractSinglePropertyField<DateTimePicker, LocalDateTime>
97-
implements Focusable<DateTimePicker>, HasAutoOpen, HasClientValidation,
96+
implements Focusable<DateTimePicker>, HasAutoOpen,
9897
InputField<AbstractField.ComponentValueChangeEvent<DateTimePicker, LocalDateTime>, LocalDateTime>,
9998
HasOverlayClassName, HasThemeVariant<DateTimePickerVariant>,
10099
HasValidationProperties, HasValidator<LocalDateTime> {

vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/main/java/com/vaadin/flow/component/shared/ClientValidationUtil.java

Lines changed: 0 additions & 58 deletions
This file was deleted.

vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/main/java/com/vaadin/flow/component/shared/HasClientValidation.java

Lines changed: 0 additions & 135 deletions
This file was deleted.

vaadin-flow-components-shared-parent/vaadin-flow-components-test-util/src/main/java/com/vaadin/tests/validation/AbstractBasicValidationTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.vaadin.flow.component.AbstractField.ComponentValueChangeEvent;
2424
import com.vaadin.flow.component.ComponentUtil;
2525
import com.vaadin.flow.component.HasValidation;
26-
import com.vaadin.flow.component.shared.HasClientValidation.ClientValidatedEvent;
2726
import com.vaadin.flow.dom.DomEvent;
2827
import com.vaadin.flow.internal.nodefeature.ElementListenerMap;
2928

@@ -66,16 +65,6 @@ public void setRequired_setManualValidation_fireUnparsableChangeEvent_noValidati
6665
Assert.assertFalse(testField.isInvalid());
6766
}
6867

69-
@Test
70-
public void setRequired_setManualValidation_fireClientValidatedEvent_noValidation() {
71-
testField.setRequiredIndicatorVisible(true);
72-
testField.setManualValidation(true);
73-
74-
ComponentUtil.fireEvent(testField,
75-
new ClientValidatedEvent(testField, false));
76-
Assert.assertFalse(testField.isInvalid());
77-
}
78-
7968
@Test
8069
public void setErrorMessage_getErrorMessage() {
8170
Assert.assertNull(testField.getErrorMessage());

vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton/RadioButtonGroup.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import com.vaadin.flow.component.dependency.NpmPackage;
3939
import com.vaadin.flow.component.radiobutton.dataview.RadioButtonGroupDataView;
4040
import com.vaadin.flow.component.radiobutton.dataview.RadioButtonGroupListDataView;
41-
import com.vaadin.flow.component.shared.HasClientValidation;
4241
import com.vaadin.flow.component.shared.HasThemeVariant;
4342
import com.vaadin.flow.component.shared.HasValidationProperties;
4443
import com.vaadin.flow.component.shared.InputField;
@@ -104,9 +103,8 @@
104103
@NpmPackage(value = "@vaadin/radio-group", version = "25.0.0-alpha3")
105104
@JsModule("@vaadin/radio-group/src/vaadin-radio-group.js")
106105
public class RadioButtonGroup<T>
107-
extends AbstractSinglePropertyField<RadioButtonGroup<T>, T>
108-
implements HasAriaLabel, HasClientValidation,
109-
HasDataView<T, Void, RadioButtonGroupDataView<T>>,
106+
extends AbstractSinglePropertyField<RadioButtonGroup<T>, T> implements
107+
HasAriaLabel, HasDataView<T, Void, RadioButtonGroupDataView<T>>,
110108
HasListDataView<T, RadioButtonGroupListDataView<T>>,
111109
InputField<AbstractField.ComponentValueChangeEvent<RadioButtonGroup<T>, T>, T>,
112110
HasThemeVariant<RadioGroupVariant>, HasValidationProperties,

vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select/Select.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import com.vaadin.flow.component.dependency.NpmPackage;
4646
import com.vaadin.flow.component.select.data.SelectDataView;
4747
import com.vaadin.flow.component.select.data.SelectListDataView;
48-
import com.vaadin.flow.component.shared.HasClientValidation;
4948
import com.vaadin.flow.component.shared.HasOverlayClassName;
5049
import com.vaadin.flow.component.shared.HasPrefix;
5150
import com.vaadin.flow.component.shared.HasThemeVariant;
@@ -115,7 +114,7 @@
115114
@JsModule("@vaadin/select/src/vaadin-select.js")
116115
@JsModule("./selectConnector.js")
117116
public class Select<T> extends AbstractSinglePropertyField<Select<T>, T>
118-
implements Focusable<Select<T>>, HasAriaLabel, HasClientValidation,
117+
implements Focusable<Select<T>>, HasAriaLabel,
119118
HasDataView<T, Void, SelectDataView<T>>, HasItemComponents<T>,
120119
InputField<AbstractField.ComponentValueChangeEvent<Select<T>, T>, T>,
121120
HasListDataView<T, SelectListDataView<T>>, HasOverlayClassName,

vaadin-text-field-flow-parent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextFieldBase.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import com.vaadin.flow.component.InputNotifier;
2828
import com.vaadin.flow.component.KeyNotifier;
2929
import com.vaadin.flow.component.shared.HasClearButton;
30-
import com.vaadin.flow.component.shared.HasClientValidation;
3130
import com.vaadin.flow.component.shared.HasValidationProperties;
3231
import com.vaadin.flow.component.shared.InputField;
3332
import com.vaadin.flow.component.shared.SlotUtils;
@@ -50,9 +49,8 @@ public abstract class TextFieldBase<TComponent extends TextFieldBase<TComponent,
5049
extends AbstractSinglePropertyField<TComponent, TValue>
5150
implements CompositionNotifier, Focusable<TComponent>, HasAriaLabel,
5251
HasAutocapitalize, HasAutocomplete, HasAutocorrect, HasClearButton,
53-
HasClientValidation, HasPrefixAndSuffix, HasValidationProperties,
54-
HasValidator<TValue>, HasValueChangeMode, HasPlaceholder, InputNotifier,
55-
KeyNotifier,
52+
HasPrefixAndSuffix, HasValidationProperties, HasValidator<TValue>,
53+
HasValueChangeMode, HasPlaceholder, InputNotifier, KeyNotifier,
5654
InputField<AbstractField.ComponentValueChangeEvent<TComponent, TValue>, TValue> {
5755

5856
private ValueChangeMode currentMode;

vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import com.vaadin.flow.component.shared.HasAllowedCharPattern;
4444
import com.vaadin.flow.component.shared.HasAutoOpen;
4545
import com.vaadin.flow.component.shared.HasClearButton;
46-
import com.vaadin.flow.component.shared.HasClientValidation;
4746
import com.vaadin.flow.component.shared.HasOverlayClassName;
4847
import com.vaadin.flow.component.shared.HasPrefix;
4948
import com.vaadin.flow.component.shared.HasThemeVariant;
@@ -117,7 +116,7 @@
117116
public class TimePicker
118117
extends AbstractSinglePropertyField<TimePicker, LocalTime>
119118
implements Focusable<TimePicker>, HasAllowedCharPattern, HasAriaLabel,
120-
HasAutoOpen, HasClearButton, HasClientValidation,
119+
HasAutoOpen, HasClearButton,
121120
InputField<AbstractField.ComponentValueChangeEvent<TimePicker, LocalTime>, LocalTime>,
122121
HasPrefix, HasOverlayClassName, HasThemeVariant<TimePickerVariant>,
123122
HasValidationProperties, HasValidator<LocalTime>, HasPlaceholder {

0 commit comments

Comments
 (0)