Skip to content

Commit 7457ff9

Browse files
committed
Address feedback
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
1 parent 00d330e commit 7457ff9

File tree

2 files changed

+60
-24
lines changed

2 files changed

+60
-24
lines changed

sources/Valkey.Glide/Abstract/IServer.cs

Lines changed: 60 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,26 +128,84 @@ public interface IServer
128128
/// </remarks>
129129
Task<ValkeyValue> EchoAsync(ValkeyValue message, CommandFlags flags = CommandFlags.None);
130130

131-
132-
131+
/// <summary>
132+
/// Get the values of configuration parameters.
133+
/// </summary>
134+
/// <seealso href="https://valkey.io/commands/config-get"/>
135+
/// <param name="pattern">The pattern to match configuration parameters. If not specified, returns all parameters.</param>
136+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
137+
/// <returns>An array of key-value pairs representing configuration parameters and their values.</returns>
133138
Task<KeyValuePair<string, string>[]> ConfigGetAsync(ValkeyValue pattern = default, CommandFlags flags = CommandFlags.None);
134139

140+
/// <summary>
141+
/// Reset the statistics reported by the INFO command.
142+
/// </summary>
143+
/// <seealso href="https://valkey.io/commands/config-resetstat"/>
144+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
135145
Task ConfigResetStatisticsAsync(CommandFlags flags = CommandFlags.None);
136146

147+
/// <summary>
148+
/// Rewrite the configuration file with the current configuration.
149+
/// </summary>
150+
/// <seealso href="https://valkey.io/commands/config-rewrite"/>
151+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
137152
Task ConfigRewriteAsync(CommandFlags flags = CommandFlags.None);
138153

154+
/// <summary>
155+
/// Set a configuration parameter to the given value.
156+
/// </summary>
157+
/// <seealso href="https://valkey.io/commands/config-set"/>
158+
/// <param name="setting">The configuration parameter to set.</param>
159+
/// <param name="value">The value to set for the configuration parameter.</param>
160+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
139161
Task ConfigSetAsync(ValkeyValue setting, ValkeyValue value, CommandFlags flags = CommandFlags.None);
140162

163+
/// <summary>
164+
/// Return the number of keys in the selected database.
165+
/// </summary>
166+
/// <seealso href="https://valkey.io/commands/dbsize"/>
167+
/// <param name="database">The database index. If -1, uses the current database.</param>
168+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
169+
/// <returns>The number of keys in the database.</returns>
141170
Task<long> DatabaseSizeAsync(int database = -1, CommandFlags flags = CommandFlags.None);
142171

172+
/// <summary>
173+
/// Delete all the keys of all databases on the server.
174+
/// </summary>
175+
/// <seealso href="https://valkey.io/commands/flushall"/>
176+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
143177
Task FlushAllDatabasesAsync(CommandFlags flags = CommandFlags.None);
144178

179+
/// <summary>
180+
/// Delete all the keys of the selected database.
181+
/// </summary>
182+
/// <seealso href="https://valkey.io/commands/flushdb"/>
183+
/// <param name="database">The database index. If -1, uses the current database.</param>
184+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
145185
Task FlushDatabaseAsync(int database = -1, CommandFlags flags = CommandFlags.None);
146186

187+
/// <summary>
188+
/// Return the UNIX timestamp of the last successful save to disk.
189+
/// </summary>
190+
/// <seealso href="https://valkey.io/commands/lastsave"/>
191+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
192+
/// <returns>The timestamp of the last successful save.</returns>
147193
Task<DateTime> LastSaveAsync(CommandFlags flags = CommandFlags.None);
148194

195+
/// <summary>
196+
/// Return the current server time.
197+
/// </summary>
198+
/// <seealso href="https://valkey.io/commands/time"/>
199+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
200+
/// <returns>The current server time.</returns>
149201
Task<DateTime> TimeAsync(CommandFlags flags = CommandFlags.None);
150202

203+
/// <summary>
204+
/// Display some computer art and the Valkey version.
205+
/// </summary>
206+
/// <seealso href="https://valkey.io/commands/lolwut"/>
207+
/// <param name="flags">Command flags are not supported by GLIDE.</param>
208+
/// <returns>A string containing computer art and version information.</returns>
151209
Task<string> LolwutAsync(CommandFlags flags = CommandFlags.None);
152210

153211
/// <summary>

sources/Valkey.Glide/Abstract/ValkeyServer.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ public Task<IGrouping<string, KeyValuePair<string, string>>[]> InfoAsync(ValkeyV
6969
public string? InfoRaw(ValkeyValue section = default, CommandFlags flags = CommandFlags.None)
7070
=> InfoRawAsync(section, flags).GetAwaiter().GetResult();
7171

72-
73-
7472
public async Task<TimeSpan> PingAsync(CommandFlags flags = CommandFlags.None)
7573
{
7674
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
@@ -101,80 +99,60 @@ public async Task<long> ClientIdAsync(CommandFlags flags = CommandFlags.None)
10199
return await _conn.Command(Request.ClientId(), MakeRoute());
102100
}
103101

104-
105-
106102
public async Task<KeyValuePair<string, string>[]> ConfigGetAsync(ValkeyValue pattern = default, CommandFlags flags = CommandFlags.None)
107103
{
108104
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
109105
return await _conn.Command(Request.ConfigGetAsync(pattern), MakeRoute());
110106
}
111107

112-
113-
114108
public async Task ConfigResetStatisticsAsync(CommandFlags flags = CommandFlags.None)
115109
{
116110
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
117111
_ = await _conn.Command(Request.ConfigResetStatisticsAsync(), MakeRoute());
118112
}
119113

120-
121-
122114
public async Task ConfigRewriteAsync(CommandFlags flags = CommandFlags.None)
123115
{
124116
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
125117
_ = await _conn.Command(Request.ConfigRewriteAsync(), MakeRoute());
126118
}
127119

128-
129-
130120
public async Task ConfigSetAsync(ValkeyValue setting, ValkeyValue value, CommandFlags flags = CommandFlags.None)
131121
{
132122
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
133123
_ = await _conn.Command(Request.ConfigSetAsync(setting, value), MakeRoute());
134124
}
135125

136-
137-
138126
public async Task<long> DatabaseSizeAsync(int database = -1, CommandFlags flags = CommandFlags.None)
139127
{
140128
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
141129
return await _conn.Command(Request.DatabaseSizeAsync(database), MakeRoute());
142130
}
143131

144-
145-
146132
public async Task FlushAllDatabasesAsync(CommandFlags flags = CommandFlags.None)
147133
{
148134
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
149135
_ = await _conn.Command(Request.FlushAllDatabasesAsync(), MakeRoute());
150136
}
151137

152-
153-
154138
public async Task FlushDatabaseAsync(int database = -1, CommandFlags flags = CommandFlags.None)
155139
{
156140
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
157141
_ = await _conn.Command(Request.FlushDatabaseAsync(database), MakeRoute());
158142
}
159143

160-
161-
162144
public async Task<DateTime> LastSaveAsync(CommandFlags flags = CommandFlags.None)
163145
{
164146
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
165147
return await _conn.Command(Request.LastSaveAsync(), MakeRoute());
166148
}
167149

168-
169-
170150
public async Task<DateTime> TimeAsync(CommandFlags flags = CommandFlags.None)
171151
{
172152
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");
173153
return await _conn.Command(Request.TimeAsync(), MakeRoute());
174154
}
175155

176-
177-
178156
public async Task<string> LolwutAsync(CommandFlags flags = CommandFlags.None)
179157
{
180158
Utils.Requires<NotImplementedException>(flags == CommandFlags.None, "Command flags are not supported by GLIDE");

0 commit comments

Comments
 (0)