Forking felixfbecker/advanced-json-rpc

[tm1000]

@danog In the past I had discussed with @muglug on forking the @felixfbecker libraries that Psalm makes use of in the language server.

See: felixfbecker/php-advanced-json-rpc#61

I think we could maintain it in the @psalm organization

I've done previous work on https://github.com/felixfbecker/php-language-server-protocol/commits/master/ and @muglug has merged it but I dont think @muglug has access to felixfbecker/php-advanced-json-rpc specifically and I think at this point it might be a good idea to bring it in here or look at using something that is more easily updatable

Either way it's going to blow up in PHP 8.5 or higher.

[Error - 8:35:11 PM] RuntimeException: PHP Error: AdvancedJsonRpc\Error::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead in /usr/src/<redacted>/app/vendor/felixfbecker/advanced-json-rpc/lib/Error.php:33 for command with CLI args "/usr/src/<redacted>/app/vendor/bin/psalm-language-server --use-extended-diagnostic-codes -c /usr/src/<redacted>/app/psalm.xml -r /usr/src/<redacted> --on-change-debounce-ms=500 --show-diagnostic-warnings=false" in /usr/src/<redacted>/app/vendor/vimeo/psalm/src/Psalm/Internal/ErrorHandler.php:76

[tm1000]

Annd just found this maintained by you: https://github.com/danog/php-advanced-json-rpc and the newest Psalm uses it. Is there any reason its not @psalm? Alternatively lets also fork php-advanced-json-rpc to you or @psalm

[danog]

Already forked to https://github.com/danog/php-advanced-json-rpc