Add throttling to pointer move event #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #163 Add throttling to pointer move events in the Canvas component to optimize coordinate recording. - Modify `packages/react-sketch-canvas/src/Canvas/index.tsx` to add throttling to the `handlePointerMove` function using a custom `useThrottledCallback` function. - Add `throttleTime` to `CanvasProps` in `packages/react-sketch-canvas/src/Canvas/types.ts` with a default value of 20. - Add `throttleTime` to `ReactSketchCanvasProps` in `packages/react-sketch-canvas/src/ReactSketchCanvas/types.ts` with a default value of 20. - Add `useThrottledCallback` function in `packages/react-sketch-canvas/src/Canvas/utils.tsx` to throttle a callback function. - Update `README.md` to include documentation on the new `throttleTime` configuration option. - Add tests to verify throttling behavior in `packages/tests/src/actions/throttling.spec.ts`. - Write vitest tests for `useThrottledCallback` function in `packages/react-sketch-canvas/src/Canvas/__test__/utils.test.tsx`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vinothpandian/react-sketch-canvas/issues/163?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Add throttling to pointer move events in the Canvas component to optimize coordinate recording.
packages/react-sketch-canvas/src/Canvas/index.tsxto add throttling to thehandlePointerMovefunction using a customuseThrottledCallbackfunction.throttleTimetoCanvasPropsinpackages/react-sketch-canvas/src/Canvas/types.tswith a default value of 20.throttleTimetoReactSketchCanvasPropsinpackages/react-sketch-canvas/src/ReactSketchCanvas/types.tswith a default value of 20.useThrottledCallbackfunction inpackages/react-sketch-canvas/src/Canvas/utils.tsxto throttle a callback function.README.mdto include documentation on the newthrottleTimeconfiguration option.packages/tests/src/actions/throttling.spec.ts.useThrottledCallbackfunction inpackages/react-sketch-canvas/src/Canvas/__test__/utils.test.tsx.For more details, open the Copilot Workspace session.