clean up TODOs

Author: frennkie

tests/core/test_archiver.py

@@ -250,8 +250,6 @@ def test_init(self):
         assert isinstance(instance.extensions, (list, KeysView))
         assert "zip" in instance.extensions
 
-    # TODO(frennkie) add tests for correct archive structure (e.g. compress file, uncompress and check dir layout)
-
     @pytest.mark.usefixtures("cleandir")
     def test_file_path_list_item_does_not_exist(self, capsys):
         assert os.listdir(os.getcwd()) == []
@@ -402,16 +400,3 @@ def test_file_without_extension(self, capsys, filename):
         assert instance.err is not None
         assert re.search("unable to discover extension", instance.err)
         assert os.listdir(os.getcwd()) == []
-
-    # @pytest.mark.parametrize("filename", ["Mac.pdf"])
-    # def test_meta(self, capsys, filename):
-    #     __sessions__.new(os.path.join(FIXTURE_DIR, filename))
-    #     instance = office.Office()
-    #     instance.command_line = ["-m"]
-    #
-    #     instance.run()
-    #     out, err = capsys.readouterr()
-    #
-    #     assert re.search(r".*comments .*| htsgraghtfgyrwthwwb*", out)
-    #     assert re.search(r".*create_time .*| 2017-03-08 16:00:00*", out)
-    #     assert re.search(r".*last_saved_time .*| 2017-04-09 19:03:00.*", out)

viper/core/session.py

@@ -86,12 +86,7 @@ def new(self, path=None, misp_event=None):
             row = Database().find(key='sha256', value=session.file.sha256)
             if row:
                 session.file.id = row[0].id
-
-                if isinstance(row[0].name, bytes):  # TODO(frennkie) check
-                    session.file.name = row[0].name.decode('utf-8')
-                else:
-                    session.file.name = row[0].name
-
+                session.file.name = row[0].name
                 session.file.tags = ', '.join(tag.to_dict()['tag'] for tag in row[0].tag)
 
                 if row[0].parent:

viper/modules/rats/hawkeye.py-deprecated

@@ -48,7 +48,7 @@ def config_1(key, salt, string_list):
     config_dict = {}
     for i in range(40):
         if len(string_list[1]) > 200:
-            # FIXME(frennkie): the next line doesn't do anything.. what could be a possible reason for it?
+            # FIXME: the next line doesn't do anything.. what could be a possible reason for it?
             config_dict["Embedded File found at {0}".format(i)]
         else:
             try:

viper/modules/sigs_helper/sigs_helper.py

@@ -51,7 +51,6 @@ def F(self, idx):
 def get_auth_data(filename):
     with open(filename, 'rb') as objf:
         fingerprinter = fingerprint.Fingerprinter(objf)
-        # is_pecoff = fingerprinter.EvalPecoff()  # TODO(frennkie) remove - is never used
         fingerprinter.EvalGeneric()
         results = fingerprinter.HashIt()