Skip to content

onPanResponderTerminationRequest cancels day selector swipes too easily #18

@bijoutrouvaille

Description

@bijoutrouvaille

Related to #1 , the pan responder is very janky inside scrollview containers. If the swiping gesture for day selector moves up or down even just a little, enough to activate the scrollview, the day selector swipe cancels. The swiper has to have a very steady hand, therefore.

I found the following line in DaySelector.react.js

onPanResponderTerminationRequest: (evt, gestureState) => true,

and changed true to false

onPanResponderTerminationRequest: (evt, gestureState) => false,

and it seems to have done the trick. Do you see potential problems with this change, or can we have that change implemented in the source?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions