Merge remote-tracking branch 'origin/main' into feat/every_commit_upload_perf_data

Author: stormslowly

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,18 +1,10 @@
-<!--
-  Thank you for submitting a pull request!
-
-  We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request.
-
-  Upon submission, your pull request will be automatically assigned with reviewers.
-
-  If you want to learn more about contributing to this project, please visit: https://github.com/web-infra-dev/rspack/blob/main/CONTRIBUTING.md.
--->
-
 ## Summary
 
-<!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? -->
+<!-- Describe what this PR does and why. -->
+
+## Related links
 
-<!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. -->
+<!-- Related issues or discussions. -->
 
 ## Checklist
 

.github/actions/rustup/action.yml

@@ -37,6 +37,7 @@ runs:
 
     - name: Restore rustup cache
       id: restore
+      if: ${{ inputs.save-if == 'true' }}
       uses: ./.github/actions/cache/restore
       with:
         path: ~/.rustup/toolchains
@@ -63,7 +64,8 @@ runs:
         key: rustup-cache-v2-${{ runner.os }}-${{ steps.get-toolchain.outputs.toolchain }}
 
     - name: Cargo cache
+      if: ${{ runner.environment != 'self-hosted' || runner.os != 'Windows' }}
       uses: ./.github/actions/rustup/cargo
       with:
         key: ${{ inputs.key }}
-        save-if: ${{ inputs.save-if }}
+        save-if: ${{ inputs.save-if == 'true' }}

.github/pr-labeler.yml

@@ -8,3 +8,5 @@
   - "/^fix/"
 "release: document":
   - "/^docs/"
+"release: refactor":
+  - "/^refactor/"

.github/release.yml

@@ -14,12 +14,15 @@ changelog:
     - title: Performance Improvements ⚡
       labels:
         - "release: performance"
-    - title: Exciting New Features 🎉
+    - title: New Features 🎉
       labels:
         - "release: feature"
     - title: Bug Fixes 🐞
       labels:
         - "release: bug fix"
+    - title: Refactor 🔨
+      labels:
+        - "release: refactor"
     - title: Document Updates 📖
       labels:
         - "release: document"

.github/teams.yml

@@ -1,5 +1,6 @@
 team:
   - "@hardfist"
+  - "@zoolsher"
   - "@h-a-n-a"
   - "@bvanjoi"
   - "@ahabhgk"
@@ -21,3 +22,5 @@ team:
   - "@Timeless0911"
   - "@GiveMe-A-Name"
   - "@stormslowly"
+  - "@quininer"
+  - "@CPunisher"

.github/workflows/ci.yml

@@ -60,6 +60,7 @@ jobs:
       runner: ${{ vars.LINUX_SELF_HOSTED_RUNNER_LABELS || '"ubuntu-22.04"' }}
       test: true
       bench: true
+      prefer_docker: false
 
   test-windows:
     name: Test Windows
@@ -69,7 +70,8 @@ jobs:
     with:
       target: x86_64-pc-windows-msvc
       profile: "dev"
-      runner: ${{ vars.WINDOWS_RUNNER_LABELS || '"windows-latest"' }}
+      runner: ${{ vars.WINDOWS_SELF_HOSTED_RUNNER_LABELS || '"windows-latest"' }}
+      test-runner: '"windows-latest"'
       test: true
 
   test-mac:

.github/workflows/ecosystem-benchmark.yml

@@ -26,18 +26,13 @@ permissions:
   pull-requests: write
 
 jobs:
-  get-runner-labels:
-    name: Get Runner Labels
-    uses: ./.github/workflows/get-runner-labels.yml
-
   build:
     name: Test Linux
-    needs: [get-runner-labels]
     uses: ./.github/workflows/reusable-build.yml
     with:
       target: x86_64-unknown-linux-gnu
-      runner: ${{ fromJSON(vars.LINUX_SELF_HOSTED_RUNNER_LABELS || '"ubuntu-latest"') }}
-      ref: ${{ github.sha }}
+      runner: ${{ vars.LINUX_SELF_HOSTED_RUNNER_LABELS ||  '"ubuntu-latest"' }}
+      ref: ${{ github.event_name == 'workflow_dispatch' && format('refs/pull/{0}/head', inputs.pr) || github.sha }}
       profile: "release"
       test: false
       bench: false
@@ -99,4 +94,4 @@ jobs:
           git config --global user.name "github-actions[bot]"
           git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
           cd rspack-ecosystem-benchmark
-          RSPACK_DIR="$RSPACK_DIR" GITHUB_ACTOR=x-access-token node bin/upload.js bench ${{ secrets.PERF_DATA_TOKEN }} ${{ github.sha }}
+          RSPACK_DIR="$RSPACK_DIR" GITHUB_ACTOR=x-access-token node bin/upload.js ${{ secrets.PERF_DATA_TOKEN }} ${{ github.sha }}

.github/workflows/preview-commit.yml

@@ -35,7 +35,7 @@ jobs:
     needs: [get-runner-labels, check-changed]
     if: needs.check-changed.outputs.changed == 'true'
     strategy:
-      fail-fast: false # Build and test everything so we can look at all the errors
+      fail-fast: true # for better utilize ci runners
       matrix:
         array:
           - target: x86_64-unknown-linux-gnu

.github/workflows/release-canary.yml

@@ -40,7 +40,7 @@ jobs:
     name: Build Canary
     needs: [get-runner-labels]
     strategy:
-      fail-fast: false # Build and test everything so we can look at all the errors
+      fail-fast: true # for better utilize ci runners
       matrix:
         array:
           - target: x86_64-unknown-linux-gnu
@@ -61,6 +61,8 @@ jobs:
             runner: ${{ needs.get-runner-labels.outputs.MACOS_RUNNER_LABELS }}
           - target: aarch64-apple-darwin
             runner: ${{ needs.get-runner-labels.outputs.MACOS_RUNNER_LABELS }}
+          - target: wasm32-wasip1-threads
+            runner: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS }}
     uses: ./.github/workflows/reusable-build.yml
     with:
       ref: ${{inputs.commit}}
@@ -91,6 +93,9 @@ jobs:
         with:
           path: artifacts
 
+      - name: Clean artifacts
+        run: find artifacts -type f -name '*.d.ts'  | xargs rm -f
+
       - name: Move artifacts
         run: node scripts/build-npm.cjs
 

.github/workflows/release-debug.yml

@@ -48,6 +48,9 @@ jobs:
         with:
           path: artifacts
 
+      - name: Clean artifacts
+        run: find artifacts -type f -name '*.d.ts'  | xargs rm -f
+
       - name: Move artifacts
         run: node scripts/build-npm.cjs