Skip to content

Commit 6d14c7a

Browse files
Remove DCHECKs in FloatRoundedRect::Radii::Expand()
The DCHECK failed when we calculated the inner bounds of an outline with border-radius, if the outline had big negative outline-offset and was on a box whose size was bigger than 2x outline width in one dimension and smaller than 2x outline width in the other dimension. In the case, FloatRoundedRect::Radii::Expand() was called with a gfx::OutsetsF with mixed positive/negative components. Remove the DCHECK as the case is valid. Will follow up for refactors and cleanups. Bug: 1301077 Change-Id: Id76b5587b83a6fd0c8fbf0dcea010dc1670f7c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499896 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/main@{#977654}
1 parent a8e347c commit 6d14c7a

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<!doctype html>
2+
<link rel="help" href="https://drafts.csswg.org/css-ui/#outline-offset">
3+
<link rel="help" href="https://crbug.com/1301077">
4+
<style>
5+
#target {
6+
width: 100px;
7+
height: 10px;
8+
border-radius: 10px;
9+
outline: 20px solid green;
10+
outline-offset: -200px;
11+
</style>
12+
<div id="target"></div>

0 commit comments

Comments
 (0)