Skip to content

Make Vite a Peer Dependency #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aklinker1 opened this issue Apr 30, 2025 · 0 comments
Open

Make Vite a Peer Dependency #1631

aklinker1 opened this issue Apr 30, 2025 · 0 comments
Milestone

Comments

@aklinker1
Copy link
Collaborator

Feature Request

I get lots of comments about this issue:

#1460 (comment)

Which would be solved by making Vite a peer and requiring all projects list a version of it in their package.json.

Is your feature request related to a bug?

N/A

What are the alternatives?

Keep it a subdependency. Only benefit here is WXT has control over the version of vite it uses, and can prevent people from trying a newer version, like v7, before it's ready.

It's easy to ignore peer dependency version warnings, while those should tell the user t hey have an invalid version installed.

@aklinker1 aklinker1 added this to the v1.0 milestone Apr 30, 2025
@aklinker1 aklinker1 mentioned this issue Apr 30, 2025
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant