Skip to content

Commit b95d598

Browse files
Remove log for DS stats keys limit (#26023)
1 parent acc3870 commit b95d598

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

ydb/core/tx/datashard/datashard__stats.cpp

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ class TTableStatsCoroBuilder : public TActorCoroImpl, private IPages, TTableStat
119119

120120
ObtainResources();
121121
Spent->Alter(true); // resume measurement
122-
122+
123123
for (auto& loaded : msg->Pages) {
124124
partPages.emplace(pageId, TPinnedPageRef(loaded.Page).GetData());
125125
PageRefs.emplace_back(std::move(loaded.Page));
@@ -151,21 +151,21 @@ class TTableStatsCoroBuilder : public TActorCoroImpl, private IPages, TTableStat
151151

152152
BuildStats(*Subset, ev->Stats, RowCountResolution, DataSizeResolution, HistogramBucketsCount, this, [this](){
153153
const auto now = GetCycleCountFast();
154-
154+
155155
if (now > CoroutineDeadline) {
156156
Spent->Alter(false); // pause measurement
157157
ReleaseResources();
158158

159159
Send(new IEventHandle(EvResume, 0, SelfActorId, {}, nullptr, 0));
160-
WaitForSpecificEvent([](IEventHandle& ev) {
161-
return ev.Type == EvResume;
160+
WaitForSpecificEvent([](IEventHandle& ev) {
161+
return ev.Type == EvResume;
162162
}, &TTableStatsCoroBuilder::ProcessUnexpectedEvent);
163163

164164
ObtainResources();
165165
Spent->Alter(true); // resume measurement
166166
}
167167
}, TStringBuilder() << "Building stats at datashard " << TabletId << ", for tableId " << TableId << ": ");
168-
168+
169169
Y_DEBUG_ABORT_UNLESS(IndexSize == ev->Stats.IndexSize.Size);
170170

171171
LOG_INFO_S(GetActorContext(), NKikimrServices::TABLET_STATS_BUILDER, "Stats at datashard " << TabletId << ", for tableId " << TableId << ": "
@@ -174,14 +174,6 @@ class TTableStatsCoroBuilder : public TActorCoroImpl, private IPages, TTableStat
174174
<< (ev->PartOwners.size() > 1 || ev->PartOwners.size() == 1 && *ev->PartOwners.begin() != TabletId ? ", with borrowed parts" : "")
175175
<< (ev->HasSchemaChanges ? ", with schema changes" : "")
176176
<< ", LoadedSize " << PagesSize << ", " << NFmt::Do(*Spent));
177-
178-
if (const auto& stats = ev->Stats; stats.DataSize.Size > 10_MB && stats.RowCount > 100
179-
&& Min(stats.RowCountHistogram.size(), stats.DataSizeHistogram.size()) < HistogramBucketsCount / 2)
180-
{
181-
LOG_ERROR_S(GetActorContext(), NKikimrServices::TABLET_STATS_BUILDER, "Stats at datashard " << TabletId << ", for tableId " << TableId
182-
<< " don't have enough keys: "
183-
<< ev->Stats.ToString());
184-
}
185177

186178
Send(ReplyTo, ev.Release());
187179

@@ -192,7 +184,7 @@ class TTableStatsCoroBuilder : public TActorCoroImpl, private IPages, TTableStat
192184
switch (ev->GetTypeRewrite()) {
193185
case TEvResourceBroker::EvTaskOperationError: {
194186
const auto* msg = ev->CastAsLocal<TEvResourceBroker::TEvTaskOperationError>();
195-
LOG_ERROR_S(GetActorContext(), NKikimrServices::TABLET_STATS_BUILDER, "Failed to allocate resource"
187+
LOG_ERROR_S(GetActorContext(), NKikimrServices::TABLET_STATS_BUILDER, "Failed to allocate resource"
196188
<< " error '" << msg->Status.Message << "'"
197189
<< " at datashard " << TabletId << ", for tableId " << TableId);
198190
throw TExTableStatsError(ECode::RESOURCE_ALLOCATION_FAILED, msg->Status.Message);
@@ -421,8 +413,8 @@ void TDataShard::Handle(TEvPrivate::TEvTableStatsError::TPtr& ev, const TActorCo
421413

422414
auto msg = ev->Get();
423415

424-
LOG_ERROR_S(ctx, NKikimrServices::TABLET_STATS_BUILDER, "Stats rebuilt error '" << msg->Message
425-
<< "', code: " << ui32(msg->Code)
416+
LOG_ERROR_S(ctx, NKikimrServices::TABLET_STATS_BUILDER, "Stats rebuilt error '" << msg->Message
417+
<< "', code: " << ui32(msg->Code)
426418
<< " at datashard " << TabletID() << ", for tableId " << msg->TableId);
427419

428420
auto it = TableInfos.find(msg->TableId);

0 commit comments

Comments
 (0)