Skip to content

Virtual chunk staleness check should be opt-out, not opt-in #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TomNicholas opened this issue Feb 18, 2025 · 0 comments · May be fixed by #480
Open

Virtual chunk staleness check should be opt-out, not opt-in #436

TomNicholas opened this issue Feb 18, 2025 · 0 comments · May be fixed by #480
Labels
enhancement New feature or request good first issue Good for newcomers Icechunk 🧊 Relates to Icechunk library / spec

Comments

@TomNicholas
Copy link
Member

The last_updated_at argument to .to_icechunk() is optional, with the default being not to set any checksum in icechunk. This means that when reading virtual chunks from the icechunk store checking that the chunks are not stale is currently opt-in.

It should be opt-out instead, as this is much safer, and there is arguably not a lot of reason to even turn this feature off. It could be implemented simply by changing the default behaviour to use the current time as the timestamp.

cc @mpiannucci

@TomNicholas TomNicholas added enhancement New feature or request good first issue Good for newcomers Icechunk 🧊 Relates to Icechunk library / spec labels Feb 18, 2025
@TomNicholas TomNicholas linked a pull request Mar 7, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Icechunk 🧊 Relates to Icechunk library / spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant