Skip to content

Watch expression on value opened in new window #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zspitz opened this issue Jun 26, 2019 · 3 comments
Open

Watch expression on value opened in new window #78

zspitz opened this issue Jun 26, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@zspitz
Copy link
Owner

zspitz commented Jun 26, 2019

When opening the value of an expression node in a new window, the WatchExpressionFormatString for the root ExpressionNodeData needs to be updated to the parent root.

@zspitz zspitz added bug Something isn't working visualizer ui labels Jun 26, 2019
@zspitz
Copy link
Owner Author

zspitz commented Jun 26, 2019

We can either recreate the watch expression in the ResolvePath function, or we can pass it along when setting the Path.

@zspitz
Copy link
Owner Author

zspitz commented Jun 26, 2019

Two functions:

  1. generate cast + access from a single path component
  2. generate cast and access from a full path

Part of the second function would be to handle values:

  • if the object is a ConstantExpression then use the Value property and cast to the narrowest public type of the object at the Value property
  • if the object is a closed-over variable MemberAccessExpression then copy the logic from ExtractValue -- wrap in a call to Lambda, Compile and Invoke

@zspitz
Copy link
Owner Author

zspitz commented Jun 26, 2019

If the debugged expression has been set in the source window, pass it along with the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant