refactor: boxes: Change OrderedDict to Dict for autocomplete mapping.

autocomplete_map is initialized as an OrderedDict to
preserve the insertion order of autocomplete prefixes
when used in generic_autocomplete to perform autocompletion
in a WriteBox.

Since Dict also preserves insertion order from python3.7,
we can safely initialize autocomplete_map as a Dict
without any change in behavior.

Author: israelsgalaxy

zulipterminal/ui_tools/boxes.py

@@ -4,7 +4,7 @@
 
 import re
 import unicodedata
-from collections import Counter, OrderedDict
+from collections import Counter
 from datetime import datetime, timedelta
 from time import sleep
 from typing import Any, Callable, Dict, List, NamedTuple, Optional, Tuple
@@ -467,18 +467,16 @@ def _stream_box_autocomplete(
         return self._process_typeaheads(matched_streams[0], state, matched_streams[1])
 
     def generic_autocomplete(self, text: str, state: Optional[int]) -> Optional[str]:
-        autocomplete_map = OrderedDict(
-            [
-                ("@_", self.autocomplete_users),
-                ("@_**", self.autocomplete_users),
-                ("@", self.autocomplete_mentions),
-                ("@*", self.autocomplete_groups),
-                ("@**", self.autocomplete_users),
-                ("#", self.autocomplete_streams),
-                ("#**", self.autocomplete_streams),
-                (":", self.autocomplete_emojis),
-            ]
-        )
+        autocomplete_map = {
+            "@_": self.autocomplete_users,
+            "@_**": self.autocomplete_users,
+            "@": self.autocomplete_mentions,
+            "@*": self.autocomplete_groups,
+            "@**": self.autocomplete_users,
+            "#": self.autocomplete_streams,
+            "#**": self.autocomplete_streams,
+            ":": self.autocomplete_emojis,
+        }
 
         # Look in a reverse order to find the last autocomplete prefix used in
         # the text. For instance, if text='@#example', use '#' as the prefix.
@@ -673,7 +671,7 @@ def autocomplete_stream_and_topic(
     def validate_and_patch_autocomplete_stream_and_topic(
         self,
         text: str,
-        autocomplete_map: "OrderedDict[str, Callable[..., Any]]",
+        autocomplete_map: Dict[str, Callable[..., Any]],
         prefix_indices: Dict[str, int],
     ) -> str:
         """