core: Update scroll prompt in Popup headers.

Replace the hardcoded scroll hints with
the commands' display keys.

Author: Niloth-p

zulipterminal/core.py

@@ -19,6 +19,7 @@
 from typing_extensions import Literal
 
 from zulipterminal.api_types import Composition, Message
+from zulipterminal.config.keys import primary_display_key_for_command
 from zulipterminal.config.symbols import POPUP_CONTENT_BORDER, POPUP_TOP_LINE
 from zulipterminal.config.themes import ThemeSpec
 from zulipterminal.config.ui_sizes import (
@@ -51,6 +52,14 @@
 
 ExceptionInfo = Tuple[Type[BaseException], BaseException, TracebackType]
 
+SCROLL_PROMPT = (
+    "("
+    + primary_display_key_for_command("GO_UP")
+    + " / "
+    + primary_display_key_for_command("GO_DOWN")
+    + " scrolls)"
+)
+
 
 class Controller:
     """
@@ -246,11 +255,11 @@ def exit_popup(self) -> None:
         self.loop.widget = self.view
 
     def show_help(self) -> None:
-        help_view = HelpView(self, "Help Menu (up/down scrolls)")
+        help_view = HelpView(self, f"Help Menu {SCROLL_PROMPT}")
         self.show_pop_up(help_view, "area:help")
 
     def show_markdown_help(self) -> None:
-        markdown_view = MarkdownHelpView(self, "Markdown Help Menu (up/down scrolls)")
+        markdown_view = MarkdownHelpView(self, "Markdown Help Menu " + SCROLL_PROMPT)
         self.show_pop_up(markdown_view, "area:help")
 
     def show_topic_edit_mode(self, button: Any) -> None:
@@ -266,7 +275,7 @@ def show_msg_info(
         msg_info_view = MsgInfoView(
             self,
             msg,
-            "Message Information (up/down scrolls)",
+            f"Message Information {SCROLL_PROMPT}",
             topic_links,
             message_links,
             time_mentions,
@@ -315,7 +324,10 @@ def show_about(self) -> None:
     def show_user_info(self, user_id: int) -> None:
         self.show_pop_up(
             UserInfoView(
-                self, user_id, "User Information (up/down scrolls)", "USER_INFO"
+                self,
+                user_id,
+                f"User Information {SCROLL_PROMPT}",
+                "USER_INFO",
             ),
             "area:user",
         )
@@ -325,7 +337,7 @@ def show_msg_sender_info(self, user_id: int) -> None:
             UserInfoView(
                 self,
                 user_id,
-                "Message Sender Information (up/down scrolls)",
+                f"Message Sender Information {SCROLL_PROMPT}",
                 "MSG_SENDER_INFO",
             ),
             "area:user",
@@ -345,7 +357,7 @@ def show_full_rendered_message(
                 topic_links,
                 message_links,
                 time_mentions,
-                "Full rendered message (up/down scrolls)",
+                f"Full rendered message {SCROLL_PROMPT}",
             ),
             "area:msg",
         )
@@ -364,7 +376,7 @@ def show_full_raw_message(
                 topic_links,
                 message_links,
                 time_mentions,
-                "Full raw message (up/down scrolls)",
+                f"Full raw message {SCROLL_PROMPT}",
             ),
             "area:msg",
         )
@@ -383,7 +395,7 @@ def show_edit_history(
                 topic_links,
                 message_links,
                 time_mentions,
-                "Edit History (up/down scrolls)",
+                f"Edit History {SCROLL_PROMPT}",
             ),
             "area:msg",
         )