Update boxes.py

Updating boxes.py to pass lint check

Fixes #1151

Update boxes.py

made users_list global by adding global keyword

Update boxes.py

user names now show id even when not adjacent

Update boxes.py

globally defined user_names_counter so it needs to be calculated only once

Update boxes.py

cleaning up the code a bit

Update boxes.py

black reformatting

made function in model.py to get username count

created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name

black reformatting

black lint

isort

isort import order

reformatting

using .get() instead of the key and removing commented out code

squashing commits

reformatting

using .get() instead of the key and removing commented out code

Author: Sushmey

zulipterminal/model.py

@@ -1151,9 +1151,7 @@ def user_name_count(self, user_name: str) -> int:
         """
         Returns the count of the users with the same name as the given name.
         """
-        if not self.user_name_dict_count[user_name]:
-            return -1
-        return self.user_name_dict_count[user_name]
+        return self.user_name_dict_count.get(user_name, -1)
 
     def _subscribe_to_streams(self, subscriptions: List[Subscription]) -> None:
         def make_reduced_stream_data(stream: Subscription) -> StreamData:

zulipterminal/ui_tools/boxes.py

@@ -76,12 +76,7 @@ def __init__(self, view: Any) -> None:
         super().__init__(self.main_view(True))
         self.model = view.model
         self.view = view
-        # global users_list  # Making it global so it can be accessed in the MessageBox class
-        # users_list = self.view.users
-        # global user_names_counter  # Making it global so it needs to be calculated only once
-        # user_names_counter = Counter(
-        #     user["full_name"] for user in users_list
-        # )  # Counting number of users having same name
+
         # Used to indicate user's compose status, "closed" by default
         self.compose_box_status: Literal[
             "open_with_private", "open_with_stream", "closed"