Skip to content

Conversation

@unnamed1337
Copy link

  • the player with connection ID 0 is no longer ignored by aimlock and esp
  • Player name and health can now be displayed

- the player with connection ID 0 is no longer ignored by aimlock and esp
- Player name and health can now be displayed
@0xDE57
Copy link
Owner

0xDE57 commented Nov 20, 2018

@unnamed1337 Thanks for the contribution! I am currently preoccupied with other projects ATM but when I get back around to this (and I do plan to, I have other stuff to add), I'll merge the your addition.

However, I will not merge the change in braces style though. I know it comes down to personal preference, but it's standard practice that you follow the coding style of the existing project. Otherwise it introduces diff noise (noise between functional and cosmetic code changes) and inconsistency and maintenance pain. EG: dev A prefers one style and dev B prefers another, they will both be changing the style each time they want to add a feature. Then say dev C comes along and adjust the style that's also different both A and B. Chaos!

This is not to say your brace style is wrong. If you change it back to the original (no new line on opening brace), it will make the merge easier for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants