-
Notifications
You must be signed in to change notification settings - Fork 23
on cluster #2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DatGuyJonathan
wants to merge
20
commits into
main
Choose a base branch
from
eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
on cluster #2944
DatGuyJonathan
wants to merge
20
commits into
main
from
eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
21fe7ee to
c6c3954
Compare
7bb0782 to
069ebb6
Compare
f7f8c50 to
5933a0f
Compare
5933a0f to
c3f78b3
Compare
c3f78b3 to
23daf2e
Compare
00d184c to
cc21483
Compare
ac3c6a4 to
651a7c7
Compare
callicles
reviewed
Nov 11, 2025
55191ed to
a2e27e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds full ClickHouse cluster (ON CLUSTER) support across CLI/migrations/DDL, TS/Py SDKs, templates, docs, and CI with new end-to-end tests.
cluster_nameto table model/proto and propagate through infra maps, planning, diffing, ordering, and display.ON CLUSTERinCREATE/ALTER/DROPand settings/index/sample/TTL SQL; preservecluster_nameduring reconcile.engineobjects.clusters/additional_databaseswhen overriding ClickHouse URL.clusters.xml.clustertoOlapConfigand serialization; forbid mixingclusterwith explicitkeeperPath/replicaName.templates/typescript-clusterandtemplates/python-clusterand corresponding E2E tests (Cluster Supportsuites) and constants.Written by Cursor Bugbot for commit c73d6f4. This will update automatically on new commits. Configure here.