Tim/eng 1174 migrate all documentation from v1 to v2 #2953
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
apps/framework-docs-v2/content/moosestack/olap/schema-optimization.mdx
Outdated
Show resolved
Hide resolved
apps/framework-docs-v2/content/moosestack/app-api-frameworks/fastify.mdx
Show resolved
Hide resolved
| playbackId: string; | ||
| title?: string; | ||
| width?: string | number; | ||
| height?: string | number; |
There was a problem hiding this comment.
Bug: Dimension props are ignored.
The width and height props are defined in the MuxVideoProps interface and destructured in the component, but they're never passed to the MuxPlayer component or used anywhere. Users passing these props will expect them to control video dimensions, but they have no effect.
| export const events = new OlapTable<EventV0>("events", { version: "0.0", orderByFields: ["id"] }); | ||
| ``` | ||
| </LanguageTabContent> | ||
| <LanguageTabContent value="python"> |
There was a problem hiding this comment.
Bug: Unify Event ID Type Declarations
The id field in EventV0 is declared as plain string but should be Key<string> to match the typing pattern used in EventV1 and maintain consistency with the table's primary key semantics across versions.
| env: "text", | ||
| dotenv: "text", | ||
| }; | ||
| const mappedLanguage = languageMap[language.toLowerCase()] || language; |
There was a problem hiding this comment.
Bug: Client-side language lookup missing null safety.
The languageMap lookup uses language.toLowerCase() without checking if language is defined first. If language is undefined, this will throw a runtime error. The server-side implementation at line 36 in server.tsx correctly handles this with a ternary check (language ? languageMap[language.toLowerCase()] || language : "typescript"), but the client-side implementation is missing this null-safety check.
tg339
force-pushed
the
tim/eng-1174-migrate-all-documentation-from-v1-to-v2
branch
2 times, most recently
from
3f3f77b to
58e7dce
Compare
tg339
force-pushed
the
tim/eng-1174-migrate-all-documentation-from-v1-to-v2
branch
from
58e7dce to
8305eb6
Compare
code sizeing new batch data insertion versioning & migration next batch next batch fix mdx-rendered and adding next batch of files adding api files fixed some language rendering and added more pages added workflows files added other workflow files streaming files added additional frameworks added new batch added top level files data modeling all files migrated initial changelog addressing cursor comments fix tabs added a bit of padding to the nav added sonner for language change fix TOC fix the build add ts ignore to mux player removed top nav fix TOC challenges
tg339
force-pushed
the
tim/eng-1174-migrate-all-documentation-from-v1-to-v2
branch
from
8305eb6 to
a76fc93
Compare
| timeoutSeconds: 3 | ||
| periodSeconds: 3 | ||
| failureThreshold: 2 | ||
| successThreshold: 5 |
There was a problem hiding this comment.
Bug: High Readiness Threshold Delays Pod Availability
The readinessProbe has successThreshold: 5 which is unusually high and likely incorrect. Kubernetes documentation and best practices typically recommend successThreshold: 1 for readiness probes (meaning the probe must succeed once to mark the pod as ready). A value of 5 means the pod needs to pass 5 consecutive health checks before being marked ready, which significantly delays traffic routing after pod startup and can cause unnecessary downtime during deployments.
Note
Adds new MDX components (video, file tree, changelog, export notice), improves TOC and code blocks, updates navigation and layout, removes legacy migration script, and adds toast/video dependencies.
MDXRendererwith new components:ExportRequirement,MuxVideo,FileTree(with subcomponents),BulletPointsCard,CompareBulletPointsCard,ToggleBlock,ZoomImg, and changelog helpers (ReleaseHighlights,Added,Changed,Deprecated,Fixed,Security,BreakingChanges).SourceCodeLinkand exposeTabs,Badge, andLinkto MDX.changelog-category.tsx,export-requirement.tsx,file-tree.tsx,mux-video.tsx.Calloutto accept string icon names.TOCNavto compute active heading via viewport logic; adjust offsets and container sizing.code-block,code-editor-wrapper,code-snippet).textin Shiki (client/server) with fallbacks.Toaster(sonner) to root layout; exposeToastercomponent.navigation.ts(addfastify,koa,raw-nodejspages).getSectionFromPathnamereturnnullfor root; guard checks in top/side nav; remove language toggle from side nav; minor padding/styling tweaks.scripts/migrate-content.ts.@mux/mux-player-reactandsonnerinpnpm-lock.yaml.Written by Cursor Bugbot for commit a76fc93. This will update automatically on new commits. Configure here.