feat: Cache awss3/awssqs Client #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtwinkle
requested review from
muziyoshiz,
bushiyama,
hienluongandpadcojp and
takayuki-2-okubo
tomtwinkle
force-pushed
the
feat/awssqs-awss3-cache-client
branch
2 times, most recently
from
b0e8a07 to
21237bb
Compare
tomtwinkle
force-pushed
the
feat/awssqs-awss3-cache-client
branch
from
21237bb to
62fdf3c
Compare
tomtwinkle
force-pushed
the
feat/awssqs-awss3-cache-client
branch
from
62fdf3c to
1caa31c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3/sqs client generates a client each time, so it had to get authentication information each time.
Since there is a high possibility that this is the cause of a large number of STS authorization processes, the client is cached and changed so that the same client is always used.
Use Cache sqs/s3 Client