Skip to content

enhancement: MinIO mc config add command has been deprecated. replace mc alias set #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

tomtwinkle
Copy link
Contributor

@github-actions github-actions bot added enhancement New feature or request lib:aws labels May 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MinIO client command in the CircleCI setup to use the new mc alias set syntax instead of the deprecated mc config host add.

  • Replace deprecated MinIO mc config host add command
  • Update to current mc alias set command
Comments suppressed due to low confidence (1)

aws/compose.yaml:31

  • The command includes an extra mc, resulting in mc mc alias set. It should be mc alias set ... without the duplicate mc prefix.
/usr/bin/mc mc alias set s3 http://minio:29000 DUMMYACCESSKEYEXAMPLE DUMMYSECRETKEYEXAMPLE;

@zveinn
Copy link

zveinn commented May 26, 2025

just wanted to give you the official seal of approval :D

Copy link

@takayuki-2-okubo takayuki-2-okubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomtwinkle tomtwinkle merged commit 78def9a into main May 27, 2025
10 checks passed
@tomtwinkle tomtwinkle deleted the enhancement/minio-mc-config-replace-alias branch May 27, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib:aws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants