-
Notifications
You must be signed in to change notification settings - Fork 1
Add support to build MOM5 with an external FMS and Generic Tracers using Spack #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
FYI, I decided not to include this commit in this PR for the sake of simplicity:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 150 sets lib_include_dirs
which is used in all the component build scripts
set lib_include_dirs = "$root/include $code_dir/shared/include $code_dir/shared/mpp/include"
I think it should also be bracketed with logic to test for external FMS.
a90562b
to
c662cd5
Compare
What's holding up getting this merged @harshula? Is it just waiting for final review/approval? |
Hi @dougiesquire , Originally it was a hack in-order to test the generic tracers. I'm not happy with the changes that I made. Can you and @aidanheerdegen work on this and come up with a neater solution? I'll drop my commits in the development branch. |
8829396
to
3e42512
Compare
least intrusive and simple way to introduce this feature.