Add a subprocess.Popen timeout when possible #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linux timeout command seems to fail terminating processes occasionally, so when possible without breaking the interface I've added a subprocess.Popen timeout (to be double the linux timeout) as a backup timeout. This is a bit hackish but has been useful for me.
nirizr
force-pushed
the
nirizr/py_timeout_backup
branch
from
aba7e62 to
86dac6d
Compare
|
same here, do you want to fix the conflict or me just copying over the changes? |
|
Fixed the conflict. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linux timeout command seems to fail terminating processes
occasionally, so when possible without breaking the interface I've added
a subprocess.Popen timeout (to be double the linux timeout) as a backup
timeout.
This is a bit hackish but has been useful for me.