Skip to content

Fix: Isolated workflow code execution in a Docker container. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BroehainIsHere
Copy link

Fixes #215. Given the lack of a discussion branch, I've submitted the PR to main.

This PR addresses the issue discussed in #215.

  • All workflow code is now executed in an isolated Docker container;
  • User code receives input via /app/input.json and must export an async code function;
  • Output and errors are captured and returned as structured JSON;
  • The container runs as a non-root user, with no network and strict resource limits;
  • A feature flag allows fallback to in-process execution for debugging.

This patch prevents cross-user code/data access and closes the RCE vector.

Copy link

@Lerenah3 Lerenah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merger is the best for y ou

Copy link

@Lerenah3 Lerenah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Copy link

@Lerenah3 Lerenah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-User Code Access via Workflow Engine RCE
2 participants