Skip to content

Conversation

@jmsexton03
Copy link
Contributor

Summary

  • Add add_uninstall_target macro to create reusable uninstall target
  • Track libamrex symlink in install manifest for proper cleanup
  • Add AMReX_cmake_uninstall.in template for uninstall script

Additional background

Previously, the libamrex symlink was not tracked in the install manifest. Newer CMake versions provide better ways to reference source locations using variables instead of hardcoded paths, allowing manifest information to be stored more accurately. The new macro also prevents conflicts when multiple projects using AMReX each try to create their own uninstall targets.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@jmsexton03 jmsexton03 requested a review from ax3l November 10, 2025 21:59
@ax3l ax3l self-assigned this Nov 11, 2025
@jmsexton03 jmsexton03 marked this pull request as ready for review November 11, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants