Skip to content

widen tolerance for grid checking in turb_box inflow generator #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

baperry2
Copy link
Contributor

@baperry2 baperry2 commented Jun 2, 2025

Grids that are actually uniform are raising an error because the current tolerance 1-e14 can be a bit to tight for determining what constitutes equal with floating point precision in the relevant calculations. Therefore, widen the tolerance to 1e-12

@baperry2 baperry2 requested a review from dmontgomeryNREL June 2, 2025 21:32
@dmontgomeryNREL
Copy link
Contributor

Is this consistent with the AMReX requirements for a uniform grid, specifically for cases with EB?

@baperry2
Copy link
Contributor Author

baperry2 commented Jun 2, 2025

This is mostly unrelated to that. We extract x,y,z,velocity data from a data file generated by a python script (which assumes a uniform grid) and map that into a FAB (which by definition has a uniform grid). The check is just to make sure that users don't abuse this tool to try to process data from other sources that didn't have a uniform grid.

@baperry2 baperry2 merged commit 170ef8e into development Jun 2, 2025
9 checks passed
@baperry2 baperry2 deleted the turb_box_tol branch June 2, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants