Skip to content

Conversation

@Conradox
Copy link
Contributor

@Conradox Conradox commented Sep 6, 2020

Required sub-tasks for this task:

  • Add generate_checkerboard function.
  • Add docstring.
  • Add information in the readme.
  • Add tests.

@Conradox Conradox added the enhancement New feature or request label Sep 6, 2020
@Conradox Conradox linked an issue Sep 6, 2020 that may be closed by this pull request
20 tasks
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           36        40    +4     
=========================================
+ Hits            36        40    +4     
Impacted Files Coverage Δ
src/SyntheticDatasets.jl 100.00% <100.00%> (ø)
src/sklearn.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf7441...0fae669. Read the comment docs.

@Conradox
Copy link
Contributor Author

Conradox commented Sep 6, 2020

@filipebraida, nesse gerador acontece o retorno de três matrizes, então aquele convert não funciona neste caso. Por causa disso criei uma outra função convert e queria que você desse uma olhada nela.

@filipebraida
Copy link
Contributor

Esse caso me colocou para pensar igual ao generate_low_rank_matrix.

Não é um problema clássico de um dataset convencional. Não sei se faz muito sentido o DataFrame. Será que vale a pena voltar Tuples de DataFrame? @Conradox

@filipebraida filipebraida added the question Further information is requested label Sep 9, 2020
@Conradox
Copy link
Contributor Author

Neste ultimo commit mudei o retorno desta função pra uma tupla, acho que realmente assim fica melhor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface para os geradores do sklearn

3 participants