-
Notifications
You must be signed in to change notification settings - Fork 642
Add ISO setting of the camera #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Can you explain what the purpose of this PR is, what problem is being solved and what behavior change you are aiming for? I can't quite tell what the point is, since it's already possible for OpenEXR to store arbitrary named metadata. |
Moreover isoSpeed has been in the implementation for years if not decades // IMF_STD_ATTRIBUTE_DEF (isoSpeed, IsoSpeed, float) |
OIIO already correctly reads and writes any of the arbitrary named metadata in an exr file (certainly for all the standard types like float and string, etc). The only time we need special handling is for particular metadata items that are very important (and important to preserve when copying image from one file format to another), and that has DIFFERENT names or different types for each file formats. In those cases, we pick one canonical name and type and have the other formats automatically translate between the internal canonical name/type and the format-specific name. An example of is this is that most formats have some kind of title, description, caption, or whatever, but they all call it something different. We chose the TIFF name for this, "ImageDescription", as our canonical name (somewhat arbitrarily, but mostly because 15 years ago, TIFF was widely used and long established). So in the openexr reader, we take the OpenEXR attribute "comments" and change it to "ImageDescription", and in the writer, we change "ImageDescription" to the standard OpenEXR attribute "comments." This basically lets you do things like
and the data will get transferred properly between the files, despite how the two formats use different nomenclature for it, and also for applications to be able to ask for a single name, "ImageDescription" to get this common data, regardless of file type, and without needing to know that it might have been different original names in different files. |
To spell it out more concretely, when we identify one of these items for which we wish to create a single canonical cross-format name for:
|
Description
ISO setting of the camera
Tests
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.