-
Notifications
You must be signed in to change notification settings - Fork 56
Create a GUI application for rawtoaces #187 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mangopep
wants to merge
11
commits into
AcademySoftwareFoundation:dev-2.0
Choose a base branch
from
mangopep:feat/gui-qt6-production
base: dev-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create a GUI application for rawtoaces #187 #191
mangopep
wants to merge
11
commits into
AcademySoftwareFoundation:dev-2.0
from
mangopep:feat/gui-qt6-production
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* add usage examples Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
* simplify core API Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> * address review issues Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> * address review issues Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> * Update src/rawtoaces_core/rawtoaces_core.cpp Co-authored-by: Aleksandr Motsjonov <soswow@users.noreply.github.com> Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> --------- Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> Co-authored-by: Aleksandr Motsjonov <soswow@users.noreply.github.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
* snake_case naming and function documentation in rawtoaces_core Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Finish renaming and descriptions in _core module Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Delete clear_vector_memory function Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Merge descriptions from cpp into h and have them only there. Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Lint formatting Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Remove mentions of specific training data set and observer details Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Fix formatting Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Fix more formatting Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Remove more specifics about training data Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Lowercase xy, uppercase CCT in func names Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * rename private calculate_WB to deconflict Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Address PR comments Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Restore max_double Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> --------- Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
…ation#183) * More consistency into naming in image_converter Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * PR review comments address Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> --------- Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
* More refactoring and descriptions Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * PR review comments address Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * changes to be deleted in next commit Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * revert to good old copy paste and simpler code Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * More PR comment address Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Fix bug where help is printed out for --list-cameras and --list-illuminants Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> --------- Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
* Fix wrong success execution Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * better comment Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> --------- Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
* test ci Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * clang formatting Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * formatting Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * Revert the revert Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> * revert the enabling Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> --------- Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
Signed-off-by: Savitha M <savithaofficial.in@gmail.com>
c81b5c9
to
804ffb9
Compare
👋 Thx for doing this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an optional Qt6 GUI for RAWtoACES with file list, parameter panel, image viewer, and real-time logs, running safely via QProcess. Adds cross-platform CI (Linux/macOS/Windows), headless Qt tests, and updated docs. Default build remains CLI-only.
Highlights
-DRAWTOACES_BUILD_GUI=ON
QT_QPA_PLATFORM=offscreen
Compatibility & Security
Checklist