chore(update IAP library to lateset version) #1405
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android billing client library from version 6.0.1 to 8.0.0 for the IAP (In-App Purchase) plugin. This is a maintenance update to use the latest version of Google's billing library.
- Updates the Android billing client dependency from version 6.0.1 to 8.0.0
| @@ -22,6 +22,6 @@ | |||
| </config-file> | |||
|
|
|||
| <source-file src="src/com/foxdebug/iap/Iap.java" target-dir="src/com/foxdebug/iap"/> | |||
There was a problem hiding this comment.
Upgrading from billing client 6.0.1 to 8.0.0 is a major version jump that likely includes breaking changes. The IAP plugin code should be reviewed and potentially updated to handle API changes, deprecated methods, and new requirements introduced in versions 7.x and 8.x of the billing library.
| <source-file src="src/com/foxdebug/iap/Iap.java" target-dir="src/com/foxdebug/iap"/> | |
| <source-file src="src/com/foxdebug/iap/Iap.java" target-dir="src/com/foxdebug/iap"/> | |
| <!-- WARNING: Upgrading to billing client 8.0.0 is a major version jump and may include breaking changes. | |
| Review and update src/com/foxdebug/iap/Iap.java and related code to handle API changes, deprecated methods, | |
| and new requirements introduced in billing client versions 7.x and 8.x. --> |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
-
Usage of querySkuDetailsAsync()
Noticed that billingClient.querySkuDetailsAsync() is being used in getProducts(). Since this method was removed in Play Billing Library 8.0.0, the recommended approach going forward is to use queryProductDetailsAsync() instead. -
Calling enablePendingPurchases() without arguments
In getBillingClient(), the call to .enablePendingPurchases() is currently used without any parameters. Just to flag, this no-argument version was also removed in 8.0.0
Replace deprecated querySkuDetailsAsync with queryProductDetailsAsync for compatibility with Google Play Billing Library v8 and higher. The migration ensures proper compatibility with modern Google Play Billing while maintaining backward compatibility for existing purchase flows.
No description provided.