-
Notifications
You must be signed in to change notification settings - Fork 10
Fix auto demotion action #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix auto demotion action #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two issues in the admin-support-cli related to GitHub Action workflow execution and issue parsing. The main goal is to ensure that workflows can run independently without breaking when no issue is present, and to correctly parse issue properties with proper case sensitivity.
- Moves issue validation from global scope to specific actions that require issues
- Fixes case-sensitive property parsing for issue duration field
- Adds error handling guard for GitHub issue comment creation
Reviewed Changes
Copilot reviewed 3 out of 16 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
admin-support-cli/src/main.ts | Relocates issue validation to action-specific cases and adds error handling guard |
admin-support-cli/src/commands/actions/check-auto-demotion-action.ts | Corrects property name from lowercase to capitalized Duration |
admin-support-cli/tests/commands/actions/check-auto-demotion-action.test.ts | Updates test mock to match corrected property name |
This PR is in response to this issue; #200 |
Ping @ActionsDesk/services-delivery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the version of @github/issue-parser
being used, and do not see the issue you mentioned regarding Duration
being case-sensitive. Can you update your branch and verify?
This PR fixes 2 issues in the admin-support-cli.
Ran
npm run all
before creating the PR to ensure the linter and tests works as expected