issue453: fix issue where hours and minutes fields are not updated when "enableKeyboardInput" is set to true #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en "enableKeyboardInput" is set to true
…en enableKeyboardInput is set to true - fix ngOnChanges usage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 95.44% 95.45% +0.01%
==========================================
Files 40 40
Lines 812 814 +2
Branches 191 192 +1
==========================================
+ Hits 775 777 +2
Misses 16 16
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
January 2, 2024 14:25
…en enableKeyboardInput is set to true - increase test coverage
…en enableKeyboardInput is set to true - fix random failures of unit tests
pfugiel
approved these changes
Feb 6, 2024
theLucasAntunes
approved these changes
Aug 7, 2024
|
could you merge these changes and release the new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue453: fix issue where hours and minutes fields are not updated when "enableKeyboardInput" is set to true