Skip to content

fix(filter-by-field): int values are failing to match when expected is parsed as short #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(filter-by-field): int values are failing to match when expected is parsed as short #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/test/java/io/aiven/kafka/connect/transforms/FilterByFieldValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,24 @@ void shouldFilterOutKeyRecordsNotEqualsToId() {
.isEqualTo(record);
}

@Test
void shouldFilterOutRecordNotEqualsToIntId() {
final FilterByFieldValue<SourceRecord> filter = new FilterByFieldValue.Value<>();
filter.configure(Map.of(
"field.name", "EventId",
"field.value", "4690",
"field.value.matches", "true"
));

assertThat(filter.apply(prepareRecord(() -> "A42", () -> Map.of("EventId", 4663))))
.as("Record with id not equal to 'A132' should be filtered out")
.isNull();
final SourceRecord record = prepareRecord(() -> "A42", () -> Map.of("EventId", 4690));
assertThat(filter.apply(record))
.as("Record with id equal to '4690' should not be filtered out")
.isEqualTo(record);
}

@Test
void shouldFilterOutMapValueRecordsWithRegex() {
final FilterByFieldValue<SourceRecord> filterByFieldValue = new FilterByFieldValue.Value<>();
Expand Down