Skip to content

Add filter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add filter #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6301b86
Fixed: Quotation bug in SMU filter method.
Mar 28, 2025
02fabe2
Added abstract filter methods to SMU device type
Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions device_types/SMU.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,21 @@ def set_range(self, unit: ChannelUnit, channel_idx: ChannelIndex, mode: SMUMode,
-> None:
pass

@abstractmethod
def toggle_filter(self, channel_idx: ChannelIndex, enable: bool, check_errors: bool = False) \
-> None:
pass

@abstractmethod
def set_filter_type(self, channel_idx: ChannelIndex, filter_type: SMUFilterType, check_errors: bool = False) \
-> None:
pass

@abstractmethod
def set_filter_count(self, channel_idx: ChannelIndex, count: int, check_errors: bool = False) \
-> None:
pass

@abstractmethod
def set_sense_mode(self, channel_idx: ChannelIndex, sense_arg: SMUSense, check_errors: bool = False) \
-> None:
Expand Down
3 changes: 2 additions & 1 deletion devices/KEI2600.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ def toggle_measure_analog_filter(self, channel_idx: ChannelIndex, enable: bool,

def toggle_filter(self, channel_idx: ChannelIndex, enable: bool, check_errors: bool = False) \
-> None:
self.execute(f'{self.__to_channel(channel_idx)}.measure.filter.enable = {self.__to_channel(channel_idx)}.{'FILTER_ON' if enable else 'FILTER_OFF'}')
self.execute(
f'{self.__to_channel(channel_idx)}.measure.filter.enable = {self.__to_channel(channel_idx)}.{"FILTER_ON" if enable else "FILTER_OFF"}')
if check_errors:
self.check_error_buffer()

Expand Down
2 changes: 1 addition & 1 deletion specifications/KEI2600.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"name": "toggle_filter",
"type": "generated",
"signature": "channel_idx: ChannelIndex, enable: bool",
"command": "f'{self.__to_channel(channel_idx)}.measure.filter.enable = {self.__to_channel(channel_idx)}.{'FILTER_ON' if enable else 'FILTER_OFF'}'"
"command": "f'{self.__to_channel(channel_idx)}.measure.filter.enable = {self.__to_channel(channel_idx)}.{\"FILTER_ON\" if enable else \"FILTER_OFF\"}'"
},
{
"name": "set_filter_type",
Expand Down