Skip to content

Updating generator to for PHP81 compatibility #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating generator to for PHP81 compatibility #447

wants to merge 1 commit into from

Conversation

funkjedi
Copy link
Contributor

@funkjedi funkjedi commented Aug 5, 2023

Supress PHP81 deprecation notices which are being thrown for generated classes implementing jsonSerialize.

Deprecated: Return type of ANetApiRequestType::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

This updates the generator to add the #[\ReturnTypeWillChange] attribute to the generated jsonSerialize methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@funkjedi