PHP 8.2 compatibility error fixes #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbumo
reviewed
Aug 29, 2023
| private function maskSensitiveProperties ($obj) | ||
|
|
||
| if(strcmp($prop->getName(), $sensitiveField->tagName) == 0) { | ||
| $prop->setValue($obj, preg_replace($inputPattern, $inputReplacement, $prop->getValue($obj))); |
There was a problem hiding this comment.
Just tested this version, and this line needs the same fix you did on line 81.
Suggested change
| $prop->setValue($obj, preg_replace($inputPattern, $inputReplacement, $prop->getValue($obj))); | |
| $prop->setValue($obj, preg_replace($inputPattern, $inputReplacement, $prop->getValue($obj) ?? '')); |
|
I didn't run into this error while testing PHP8.2 support in our application. I will need to update our forked version. Thank you for sharing your changes. I did see a deprecation notice that you can no longer dynamically declare a property and need to include |
deatonsandra21
approved these changes
Jan 26, 2024
|
+1 on this, curious if this would fix upto 8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.