-
Notifications
You must be signed in to change notification settings - Fork 34
Upstream merges (#28) #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merged Develop upstream
This reverts commit bd53446.
Merged Develop upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces OpenCV functionality to the AMC Framework by adding a new OpenCV driver. The changes include adding OpenCV as a submodule and implementing a wrapper library for OpenCV computer vision capabilities.
- Added OpenCV as a Git submodule for computer vision capabilities
- Implemented new OpenCV wrapper library with ACT-generated interfaces for image loading, processing, and saving
- Added build configuration and project files for Windows 64-bit development
Reviewed Changes
Copilot reviewed 111 out of 872 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
Drivers/OpenCV/LibOpenCV/include/ | OpenCV header files for core functionality including CUDA support, image processing, and calibration |
Drivers/OpenCV/LibOpenCV/Interfaces/ | ACT-generated C++ wrapper interfaces for the OpenCV library |
Drivers/OpenCV/LibOpenCV/build_resource_win64.bat | Windows batch script for building the OpenCV wrapper library |
Comments suppressed due to low confidence (1)
Drivers/OpenCV/LibOpenCV/include/opencv2/core/cuda/common.hpp:1
- Inconsistent use of apostrophes in license text. Line 20 correctly uses 'Redistribution's' but line 23 uses 'Redistribution's' with a different apostrophe character.
/*M///////////////////////////////////////////////////////////////////////////////////////
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
void CLibOpenCVInterfaceJournalEntry::addInt32Parameter(const std::string & sName, const LibOpenCV_int32 nValue) | ||
{ | ||
addParameter(sName, "uint32", std::to_string(nValue)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type mismatch in parameter logging. The function addInt32Parameter should use 'int32' as the parameter type, not 'uint32'.
addParameter(sName, "uint32", std::to_string(nValue)); | |
addParameter(sName, "int32", std::to_string(nValue)); |
Copilot uses AI. Check for mistakes.
|
||
void CLibOpenCVInterfaceJournalEntry::addInt32Result(const std::string & sName, const LibOpenCV_int32 nValue) | ||
{ | ||
addResult(sName, "uint32", std::to_string(nValue)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type mismatch in result logging. The function addInt32Result should use 'int32' as the result type, not 'uint32'.
addResult(sName, "uint32", std::to_string(nValue)); | |
addResult(sName, "int32", std::to_string(nValue)); |
Copilot uses AI. Check for mistakes.
Added SPI and Enums to Raylase SDK
Added CMake Min Version 3.10
Added raylase nLight Driver board status update
Deactivated SPI
Added JSON API classes
Added JSON API classes
Fixed JSON Array Implementation
Scanlab SCM Driver: Added Blend Mode, Configuration Patching
Added Remove Children into XLM Document Node
Fixed Layerview point viewer clearing
Updated Client
Fixed external JSON API
Added Raylase Part Suppression
Fixed Journal Reader
Improved Examples
Fixed crash in image format conversion
Raylase Driver: Added part suppression and fixes callback issues
Fixed Visual Studio 2022
Added UUID Values to JSON Wrapper
Removed TSL and AML Drivers for now
Replaced libjpeg-turbo
Replaced libjpeg-turbo
Implemented JPEG ImageData export/import
JPEG Image loader
Added create Client Dist executable
Linux compile fixes
Linux fixes
Linxu compile fixes
Linxu compile fixes
Updated Camera driver
Updated Example to include camera driver
Added Raylase NLight Driver Implementation
nLight Driver Implementation
Compile fixes for Camera driver
Updated nLight Board API
Implemented Raylase Driver SPI Status and mode dependent max laser power
Raylase Driver: Added 3D Movements
Added Delays for initialization
Raylase Driver: Disarmed before initialization
Updated Lib3MF
Updated Boolean artifact
Added RTC Defocus Factors
Updated API for Lib3MF Update
Scanlab SMC SDK: added headers for power ramps
Refactored Toolpath Layer Interfaces
Updated Raylase driver to API changes
Updated Lib3MF
Updated Lib3MF
Updated Lib3MF API
Refactored layer reader and removed loop toolpath type
Updated Lib3MF Branch
Fixed OIE Recording round trip bit
Updated Lib3MF Binary
Fixed warning in RTC Driver
Add Toolpath SubInterpolation Hatch Data
SMC Driver: Added Power Ramps
Made Power output calibration properly linear in scanlab driver
Added Custom Page update flag
Updated Client Package
Added Pre and Post Segment Delay profile settings
Added Support for Presegment and Postsegment Delays
Added Microvector support for Scanlab Driver
Typo in Scanlab driver
Added JSON Event Streaming
Fixed Stream Connection
Small camera driver fixes for enumerating device information
Scanlab SMC Driver: Fixed IPAddress initialization
Added Machine Resources to Working Directory
Added first OpenCV Driver
Updated OpenCV Build script
OpenCV Driver: Implemented WriteToImage
Linux compile fix
Added OpenCV Windows UTF8 Workaround
Added Microsecond options to RTC Skywriting profiles
Adds support for loading SCANmotionControl.dll v1.0 and its dependency RTCService.dll (Update lib3mf linux amd64 binary #22)
Scanlab SMC Driver: Adds support for loading SCANmotionControl.dll v1.0 and its dependency RTCService.dll
Implements the loading of SCANmotionControl.dll v1.0 and its dependency RTCService.dll
Implements the execution of Build using SCANmotionControl.dll v1.0
Scanlab SMC Driver: Implemented Additional API for Loading RTCService.dll
Added methods SetRTCServiceDLLResourceName and SetRTCServiceDLLResourceData to support loading of RTCService.dll.
Restored the previous method signatures for SetDLLResources and SetCustomDLLData.
Signed-off-by: Yury Rodzikau y.rodzikau@c1-technologies.com
Signed-off-by: Yury Rodzikau y.rodzikau@c1-technologies.com
Updated SMC Configuration to include Correction Files
Fixed Send To Hardware in SMC Context Instance
Fixed Scanlab Predelay Bug
Scanlab RTC Fix for Hatch Coordinates
Fixed GPIO Sequence Repeat loop
Scanlab Driver: Fixed MCBSP On the Fly Override for OIE Recording
Scanlab OIE: Added Selectable Recording Frequency
Scanlab Driver: Improved OIE Measurement Tag handling
Fixed issue in measurement Tag map
Included first OpenFOAM Driver
Removed fly_2d fix from Scanlab OIE Control Power setting
Added 3MF Binary metadata access by Relationship
Updated Lib3mf
Added Mesh handling to Builds, Extended Working files with writers
Updated Lib3mf
OpenFOAM STL generation
Implements a CSV parser to parse Simulation or rtc_log_record files (windows build #24)
Scanlab SMC Driver: Implements loading RTC6 PCIe Firmware
Implements RTC6 PCIe firmware loading if the RTC6 Ethernet IP Address is not specified in the configuration file.
Implements copying of the xml node of the configuration file.
Scanlab SMC Driver: Implements a CSV parser to parse Simulation or rtc_log_record files
Implements a universal customizable CSV parser to parse Simulation or rtc_log_record files for SCANmotionControl V1.0
Maintains backward compatibility with SCANmotionControl V0.8/0.9
Upgrade C++ Language Standard for libmcdriver_scanlabsmc to C++17
Added Triangle Set Access to Mesh Objects
OpenFOAM Driver
Scanlab SMC Driver: Added PCI Support
Updated Lib3mf
Linux fixes
Linux fixes
linux fixes
linux fixes
OpenFOAM Driver: Improved Driver Montoring
Added working File Processes to API
Updated OpenFOAM Driver
Added Working File processes
Compile fixes
Added new OpenCV Wrapper DLL
Added new OpenCV Wrapper DLL
Scanlab SMC Driver: Upgrade of the SCANmotionControl to v1.1 (Initial version of AMCF GitHub Page #26)
Support for SCANmotion library version v1.1 has been implemented;
Backward compatibility with SCANmotion version v1.0 has been preserved.
Scanlab SMC Driver: Refactored CSMCJobInstance::ReadSimulationFile to… (Merge Develop into Master #25)
Scanlab SMC Driver: Refactored CSMCJobInstance::ReadSimulationFile to Support Parser Selection Based on SMC Version
Implements logic to select the appropriate SimulationData parser dynamically based on the detected SCANmotionControl version.
Restored the previous SMCJob interface to ensure backward compatibility with existing code.
Scanlab SMC Driver: Implemented UTF-8 file path support for Windows in simulation file loading
Added platform-specific handling to support long UTF-8 file paths on Windows using MultiByteToWideChar.
Implemented exception generation in AMCF style.
Scanlab SMC Driver: Implements parsing and storing the “laseron” signal as uint32_t instead of bool
Implements parsing and storing the “laseron” signal as uint32_t instead of bool
Added External Process Execution to Driver Environment
Added first Unit Test Framework
Added first Unit Test Framework
Fixed process controller
Fixed Linux build
Refactored Working Directories and added Subdirectory support
Refactored Working Directories and added Subdirectory support
Updated OpenFOAM driver
Linux fixes
Linux fixes
Linux fixes
Added custom Correction factors to Scanlab driver
Linux fixes
Linux fixes
Linux fixes
Linux fixes
Linux fixes
Linux fixes
LibMCEnv: Implements LaserON signal visualization in WebGUI (Read ExtrusionFactor and Speed from 3mf metadata. #27)
LibMCEnv: Implements LaserON signal visualization in WebGUI
Extends the DataTableScatterPlotOptions class with the ListDataChannels method for storing and transmitting LaserOn signal;
Implements the ScatterPlotDataChannel(Iterator), ScatterPlotDataColumn(Iterator) classes for storing and transferring additional channels and data columns;
Implements saving and querying of LaserOn signal status to/from the database;
Implements additional HTTP request for acquiring LaserOn signal data on the WebGUI side;
implements additional "LaserOn" mode for LaserOn signal visualization in WebGUI;
AMCF WebClient: Fix incorrect async method invocation in Vue and JS layers
queryPoints: added
return
to ensure caller can await result of async callqueryPointsChannelData: added
return
to propagate async result to calling contextonLayerChanged: added async handling to prevent race conditions during updates
AMCF WebClient/Artifacts: Contains updated client packages with updated githash
Contains updated client packages with updated githash
Scanlab driver: Added laser timing defaults for RTC Drivers
Refactored Signal handling
Updated Client Distribution
Fixed Signal Handling
fixed LPBF User Interface
Updated Unit Test Framework
Linux fixes
Unit Tests
Added Automatic unit testing to Develop branch
Updated build script
Updated build script
Disabled client check on Linux
added libuuid dependency
First iteration of Machine Configurations in LibMCData
Added Machine Configuration Data Model
Signed-off-by: Yury Rodzikau y.rodzikau@c1-technologies.com