Skip to content

Update Jetpack_Notifications::print_js() to be CSP-compatible #45878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+13 −8
Open

Update Jetpack_Notifications::print_js() to be CSP-compatible #45878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions projects/plugins/jetpack/modules/notes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,17 +232,22 @@ private static function get_notes_markup() {
*/
public function print_js() {
$link_accounts_url = is_user_logged_in() && ! ( new Connection_Manager( 'jetpack' ) )->is_user_connected() ? Jetpack::admin_url() : false;
ob_start();
?>
<script data-ampdevmode type="text/javascript">
/* <![CDATA[ */
var wpNotesIsJetpackClient = true;
var wpNotesIsJetpackClientV2 = true;
<script>
var wpNotesIsJetpackClient = true;
var wpNotesIsJetpackClientV2 = true;
<?php if ( $link_accounts_url ) : ?>
var wpNotesLinkAccountsURL = '<?php echo esc_url( $link_accounts_url ); ?>';
<?php endif; ?>
/* ]]> */
</script>
var wpNotesLinkAccountsURL = <?php echo wp_json_encode( $link_accounts_url, JSON_HEX_TAG | JSON_UNESCAPED_SLASHES ); ?>;
<?php endif; ?>
</script>
<?php
wp_print_inline_script_tag(
str_replace( array( '<script>', '</script>' ), '', ob_get_clean() ),
array(
'data-ampdevmode' => true,
)
);
}

/**
Expand Down
Loading