-
Notifications
You must be signed in to change notification settings - Fork 841
WPSC: Remove outside dependency device detection #45879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Super Cache plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
3 files are newly checked for coverage.
Coverage check overridden by
I don't care about code coverage for this PR
|
donnchawp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for sorting out that problem.
Fixes #45784
Fixes FORMS-389
Proposed changes:
The JP ecosystem expects the JP autoloader to load the latest version of a package, no matter which plugin provides it. WPSC hardcoded it's own included version resulting in issues where other JP plugins are expecting a new version of this package, but it is not available.
Since WPSC is legacy, electing to embed the code instead of adding the autoloader. This ensures that future development of the package won't have a knock-on effect to WPSC without more intentional inclusion.
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no.
Testing instructions: