Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Nov 11, 2025

Fixes #45784
Fixes FORMS-389

Proposed changes:

  • Adds the device detection code directly into WPSC.

The JP ecosystem expects the JP autoloader to load the latest version of a package, no matter which plugin provides it. WPSC hardcoded it's own included version resulting in issues where other JP plugins are expecting a new version of this package, but it is not available.

Since WPSC is legacy, electing to embed the code instead of adding the autoloader. This ensures that future development of the package won't have a knock-on effect to WPSC without more intentional inclusion.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no.

Testing instructions:

  • TBA

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Nov 11, 2025
@github-actions github-actions bot added [Plugin] Super Cache A fast caching plugin for WordPress. [Status] In Progress labels Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Super Cache plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 11, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/super-cache/plugins/jetpack.php 0/56 (0.00%) 0.00% -1 💚

3 files are newly checked for coverage.

File Coverage
projects/plugins/super-cache/src/device-detection/class-device-detection.php 0/25 (0.00%) 💔
projects/plugins/super-cache/src/device-detection/class-user-agent-info.php 0/1049 (0.00%) 💔
projects/plugins/super-cache/src/device-detection/functions.php 0/6 (0.00%) 💔

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@kraftbj kraftbj added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Nov 11, 2025
@kraftbj kraftbj marked this pull request as ready for review November 11, 2025 22:11
@kraftbj kraftbj requested a review from a team November 11, 2025 22:28
donnchawp
donnchawp previously approved these changes Nov 12, 2025
Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for sorting out that problem.

@kraftbj kraftbj merged commit 3af959f into trunk Nov 14, 2025
67 checks passed
@kraftbj kraftbj deleted the remove/wpsc/outside-dep-device-detection branch November 14, 2025 18:00
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 14, 2025
@github-actions github-actions bot added this to the super-cache/1.12.5 milestone Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Super Cache A fast caching plugin for WordPress. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal Error: User_Agent_Info::get_browser_display_name method undefined

4 participants