feat(vscode): add container support for extension dependencies - [Do not merge] #8229

ccastrotrejo · 2025-09-10T23:21:33Z

Commit Type

feature - New functionality

Risk Level

High - Major changes, significant user/system impact

What & Why

This PR implements container support for the VS Code Logic Apps extension by removing local dependency management and adding containerized runtime support. The changes include:

Removal of binary validation and installation logic for .NET, Node.js, and Azure Functions Core Tools
Addition of Azure Functions Core Tools download in the container Dockerfile
Simplification of project setup by using system-installed binaries instead of managed dependencies
Updated VS Code tasks to use standard commands (dotnet, func) instead of configuration-based paths

Impact of Change

Users: Simplified setup experience when using containers - no more dependency management
Developers: Cleaner codebase with reduced complexity around binary management
System: Container-based workflow with pre-installed runtime dependencies

Test Plan

Manual testing completed
Unit tests added/updated
E2E tests added/updated
Tested in: Container development environment

Contributors

@ccastrotrejo

Screenshots/Videos

N/A - Backend infrastructure changes

…trotrejo/containerExtension

github-actions · 2025-09-10T23:22:03Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: feat(vscode): add container support for extension dependencies - [Do not merge]
Issue: The title is descriptive and follows the feat(vscode): ... convention. The "[Do not merge]" tag is helpful for reviewers. No issue found.
Recommendation: No changes needed. If ready to merge, remove "[Do not merge]".

✅ Commit Type

Properly selected (feature - New functionality).
Only one type selected, which is correct.

✅ Risk Level

Risk is set to "High" in both the PR body and label (Risk:High).
This matches the code diff, which has extensive, breaking and architectural changes. No mismatch.

✅ What & Why

Current:

This PR implements container support for the VS Code Logic Apps extension by removing local dependency management and adding containerized runtime support. The changes include:

Removal of binary validation and installation logic for .NET, Node.js, and Azure Functions Core Tools

Addition of Azure Functions Core Tools download in the container Dockerfile

Simplification of project setup by using system-installed binaries instead of managed dependencies

Updated VS Code tasks to use standard commands (dotnet, func) instead of configuration-based paths

Issue: All required context is provided, including specific technical highlights.
Recommendation: No action needed.

✅ Impact of Change

Clear impact statements for Users, Developers, and System. Indicates major setup and workflow alterations.
Recommendation:
- Users: No additional notes. The section is clear.
- Developers: No additional notes. Coverage is precise.
- System: No additional notes.

✅ Test Plan

Manual testing is marked completed. Unit/E2E are not checked, which matches diff (heavy infrastructure/arch change that may be hard to fully automate immediately). Also notes "Tested in container development environment".
Test plan is adequate, but as a nudge: if feasible, recommend incrementally adding more automation as container workflows stabilize.

✅ Contributors

Single contributor (@ccastrotrejo) listed.
No issues. As a reminder: in future, tag PMs/designers if they contributed ideas/review.

✅ Screenshots/Videos

Marked "N/A - Backend infrastructure changes". This is correct given non-UI nature of changes.

Summary Table

Section	Status	Recommendation
Title	✅	If ready to merge, remove [Do not merge]
Commit Type	✅	Correct
Risk Level	✅	Correct
What & Why	✅	Correct
Impact of Change	✅	Correct
Test Plan	✅	Consider further automation if feasible
Contributors	✅	Tag additional contributors if applicable
Screenshots/Videos	✅	Correct

All required sections are complete and correct. This PR passes title and body review.

If this PR is no longer "do not merge" status, please update the title before merging.

If this change impacts rollout/documentation, consider communicating out to relevant users/developers ahead of time due to the scope/breaking nature of containerization.

Last updated: Mon, 13 Oct 2025 18:43:05 GMT

…trotrejo/containerExtension

Copilot

Pull Request Overview

This PR implements containerization support for the Azure Logic Apps VS Code extension while removing deprecated dependency management features. The changes streamline the extension by eliminating binary validation and installation functionality, replacing it with Docker container support for development environments.

Key changes:

Removes binary dependency management system for Node.js, .NET SDK, and Azure Functions Core Tools
Adds Docker container support with devcontainer configuration
Simplifies extension configuration by removing numerous settings and commands related to binary validation

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
apps/vs-code-designer/src/package.json	Removes dependency validation commands and configuration settings
apps/vs-code-designer/src/onboarding.ts	Deletes the onboarding module that handled binary installation
apps/vs-code-designer/src/main.ts	Replaces binary installation with direct design-time API startup
apps/vs-code-designer/src/container/	Adds Docker container configuration files for development
Multiple utility files	Updates hardcoded binary paths to use standard command names

apps/vs-code-designer/src/main.ts

apps/vs-code-designer/src/container/devcontainer.json

apps/vs-code-designer/src/app/utils/dotnet/executeDotnetTemplateCommand.ts

apps/vs-code-designer/src/app/commands/workflows/unitTest/runUnitTest.ts

apps/vs-code-designer/src/app/utils/bundleFeed.ts

apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts

apps/vs-code-designer/src/app/commands/initProjectForVSCode/initScriptProjectStep.ts

…trotrejo/containerExtension

Copilot

Pull Request Overview

Copilot reviewed 94 out of 94 changed files in this pull request and generated 4 comments.

apps/vs-code-designer/src/app/utils/vsCodeConfig/settings.ts

apps/vs-code-designer/src/app/commands/createWorkspace/createWorkspaceSteps/devcontainerStep.ts

apps/vs-code-designer/src/constants.ts

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…trotrejo/containerExtension

Copilot

Pull Request Overview

Copilot reviewed 100 out of 100 changed files in this pull request and generated 7 comments.

Copilot · 2025-10-10T15:49:53Z

apps/vs-code-designer/src/app/utils/vsCodeConfig/tasks.ts

          {
            label: 'generateDebugSymbols',
-            command: '${config:azureLogicAppsStandard.dotnetBinaryPath}',
+            command: 'dotnet',


[nitpick] Consider making these command names configurable through constants to maintain consistency across the codebase and ease future updates.

Copilot · 2025-10-10T15:49:53Z

apps/vs-code-designer/src/constants.ts

+export const managementApiPrefix = 'runtime/webhooks/workflow/api/management';
+export const designerStartApi = 'runtime/webhooks/workflow/api/management/operationGroups';


The removal of leading slash from API paths could cause issues when concatenating URLs. Ensure all usages properly handle the path joining.

Suggested change

export const managementApiPrefix = 'runtime/webhooks/workflow/api/management';

export const designerStartApi = 'runtime/webhooks/workflow/api/management/operationGroups';

export const managementApiPrefix = '/runtime/webhooks/workflow/api/management';

export const designerStartApi = '/runtime/webhooks/workflow/api/management/operationGroups';

Copilot · 2025-10-10T15:49:54Z

apps/vs-code-designer/src/app/utils/unitTests.ts

  const solutionName = 'Tests'; // This will create "Tests.sln"
  const solutionFile = path.join(testsDirectory, `${solutionName}.sln`);
-  const dotnetBinaryPath = getGlobalSetting(dotNetBinaryPathSettingKey);
+  const dotnetCommand = 'dotnet';


[nitpick] This hardcoded command should use a constant from the constants file to maintain consistency with other command references.

Copilot · 2025-10-10T15:49:54Z

apps/vs-code-designer/src/app/utils/dotnet/executeDotnetTemplateCommand.ts

+    const versions = '8';

    // Prioritize "LTS", then "Current", then "Preview"
-    const netVersions: string[] = ['8', '6', '3', '2', '9', '10'];
+    const netVersions: string[] = ['8', '6'];


[nitpick] The hardcoded version strings should be moved to constants to make version management more maintainable.

Copilot · 2025-10-10T15:49:54Z

apps/vs-code-designer/src/app/utils/extension.ts

+export async function getPublicUrl(url: string) {
+  const local = vscode.Uri.parse(url);
+  const external = await vscode.env.asExternalUri(local);
+  return external.toString(); // use this in webviews, auth callbacks, logs, etc.
+}


Add JSDoc documentation explaining the purpose of this function and when it should be used, especially in container environments.

Copilot · 2025-10-10T15:49:55Z

...code-designer/src/app/commands/createWorkspace/createWorkspaceSteps/workspaceSettingsStep.ts

    if (context.workspacePath && context.workspaceFilePath.endsWith('.code-workspace') && fs.existsSync(context.workspaceFilePath)) {
      await this.updateWorkspaceFile(context);
-      context.openBehavior = OpenBehavior.addToWorkspace;
+      context.openBehavior = OpenBehavior.openInNewWindow;


[nitpick] The hardcoded change from 'addToWorkspace' to 'openInNewWindow' should be documented or made configurable, as this changes user workflow behavior.

Suggested change

context.openBehavior = OpenBehavior.openInNewWindow;

// [NOTE] Default behavior changed from 'addToWorkspace' to 'openInNewWindow'.

// To restore previous behavior, set 'context.openBehaviorPreference' to 'OpenBehavior.addToWorkspace'.

context.openBehavior = context.openBehaviorPreference ?? OpenBehavior.openInNewWindow;

Copilot · 2025-10-10T15:49:55Z

apps/vs-code-designer/src/app/utils/vsCodeConfig/settings.ts

-function osSupportsVersion(version: FuncVersion | undefined): boolean {
-  return version !== FuncVersion.v1 || process.platform === Platform.windows;
+function osSupportsVersion(): boolean {
+  return process.platform === Platform.windows;


This function now only returns true for Windows platform, which may cause issues on Linux/Mac container environments where the function is still called.

Suggested change

return process.platform === Platform.windows;

// Assume all platforms are supported unless there is a known limitation.

return true;

…trotrejo/containerExtension

ccastrotrejo added 3 commits September 10, 2025 16:48

Initialize container docs

b71464a

Remove unused files

93c78c2

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

f9c2d20

…trotrejo/containerExtension

github-actions bot added the needs-pr-update label Sep 10, 2025

ccastrotrejo added 9 commits September 10, 2025 19:31

Update dependencies settings

2a63e52

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

851b5a5

…trotrejo/containerExtension

Delete more code

260258a

Remove constants

73d8bf0

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

8c3f1b2

…trotrejo/containerExtension

Remove extension bundle installation

87a84cd

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

1e4752c

…trotrejo/containerExtension

Add extension bundle download

32f58b5

Add Azure Functions Core Tools download to container Dockerfile

544e9cc

ccastrotrejo marked this pull request as ready for review September 15, 2025 14:28

Copilot AI review requested due to automatic review settings September 15, 2025 14:28

ccastrotrejo changed the title ~~Ccastrotrejo/container extension~~ feat(vs-code-designer): add container support with Azure Functions Core Tools Sep 15, 2025

ccastrotrejo added the Risk:High High risk change requiring careful review label Sep 15, 2025

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

f3d9b25

…trotrejo/containerExtension

github-actions bot added pr-validated and removed needs-pr-update labels Sep 15, 2025

Copilot AI reviewed Sep 15, 2025

View reviewed changes

Complete container integration with func binary linking

4984fab

ccastrotrejo changed the title ~~feat(vs-code-designer): add container support with Azure Functions Core Tools~~ feat(vscode): add container support with Azure Functions Core Tools Sep 15, 2025

ccastrotrejo changed the title ~~feat(vscode): add container support with Azure Functions Core Tools~~ feat(vscode): add container support for extension dependencies Sep 15, 2025

ccastrotrejo added 5 commits September 16, 2025 16:56

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

753fe02

…trotrejo/containerExtension

Remove extension bundle func

6014306

Add script to update the extension bundle reference

0652615

Add scripts

6b98a58

Update DOCKERFIle

5888703

ccastrotrejo added 7 commits October 2, 2025 12:44

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

4d71b81

…trotrejo/containerExtension

Commit open container and fix func issues

eeb1b12

Update func core tools

8348eae

Revert func

7d8673b

Update docker file and add readme and shell command to build and publish

b6b2165

Update docker build command to adjust to multi platform

0cf4c17

Update package.json to remove dev container

7980dfc

ccastrotrejo requested a review from Copilot October 3, 2025 19:25

Copilot AI reviewed Oct 3, 2025

View reviewed changes

ccastrotrejo added 4 commits October 7, 2025 21:07

Keep just one README file

397389d

Update readme and docker file

eafdb45

Update read me

2e189db

update docker file

ca708f8

ccastrotrejo requested a review from Copilot October 8, 2025 15:53

Revert back md file changes

ad0e994

Copilot AI reviewed Oct 8, 2025

View reviewed changes

ccastrotrejo added 4 commits October 8, 2025 15:49

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

7ef1a3d

…trotrejo/containerExtension

Add get public url function

d063059

Update unit tests

ee33af5

Update path

f5387ad

ccastrotrejo requested a review from Copilot October 10, 2025 15:48

Copilot AI reviewed Oct 10, 2025

View reviewed changes

ccastrotrejo added 8 commits October 13, 2025 15:44

Updare local url

54ab7d0

Add github token for codespaces

41a7595

Remove docker compose and just rely on the image

4c58fd1

Fix typo

83a3fb9

Revert back github token

22ceaa9

Add ports visibility

6580523

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into ccas…

dc84dab

…trotrejo/containerExtension

Update test

1bd2f25

		export const managementApiPrefix = 'runtime/webhooks/workflow/api/management';
		export const designerStartApi = 'runtime/webhooks/workflow/api/management/operationGroups';

-      context.openBehavior = OpenBehavior.openInNewWindow;
+      // [NOTE] Default behavior changed from 'addToWorkspace' to 'openInNewWindow'.
+      // To restore previous behavior, set 'context.openBehaviorPreference' to 'OpenBehavior.addToWorkspace'.
+      context.openBehavior = context.openBehaviorPreference ?? OpenBehavior.openInNewWindow;

	return process.platform === Platform.windows;
	// Assume all platforms are supported unless there is a known limitation.
	return true;

feat(vscode): add container support for extension dependencies - [Do not merge] #8229

Are you sure you want to change the base?

feat(vscode): add container support for extension dependencies - [Do not merge] #8229

Uh oh!

Conversation

ccastrotrejo commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Commit Type

Risk Level

What & Why

Impact of Change

Test Plan

Contributors

Screenshots/Videos

Uh oh!

github-actions bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

✅ Risk Level

✅ What & Why

✅ Impact of Change

✅ Test Plan

✅ Contributors

✅ Screenshots/Videos

Summary Table

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

ccastrotrejo commented Sep 10, 2025 •

edited

Loading

github-actions bot commented Sep 10, 2025 •

edited

Loading