Skip to content

Conversation

lambrianmsft
Copy link
Contributor

@lambrianmsft lambrianmsft commented Oct 7, 2025

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

We are updating the create logic app workspace, create new project, create workspace from zip, and convert to project from using vscode wizards to a custom webview. This custom webview will give users one page to go over all the required fields instead of only seeing one field prompted at a time. This provides a simpler and more intuitive interface without making users remember what they have previously input. This change also updated underlying functionality to be more simple, which will help maintainability and to prevent users from encountering inconsistent behaviors with project or file creation.

Impact of Change

  • Users: Users will now input all the required fields through a webview instead of going through a wizard.
  • Developers: Steps previously coupled to a wizard are now decoupled and moved into functions.
  • System: Processing methods are now outside of wizard execution steps.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Screenshots/Videos

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 00:41
Copy link

github-actions bot commented Oct 7, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(vscode): Refactor wizard inputs to webview for workspace creation
  • Issue: Title is clear, descriptive, and follows common conventions.
  • Recommendation: None needed, the title is high quality.

Commit Type

  • Properly selected (refactor)
  • Only one selected, which is correct.

Risk Level

  • High risk was selected in both the PR body and label, which matches the scale and significance of the changes described and code diff.

What & Why

  • Current: We are updating the create logic app workspace, create new project, create workspace from zip, and convert to project from using vscode wizards to a custom webview. This custom webview will give users one page to go over all the required fields instead of only seeing one field prompted at a time. This provides a simpler and more intuitive interface without making users remember what they have previously input. This change also updated underlying functionality to be more simple, which will help maintainability and to prevent users from encountering inconsistent behaviors with project or file creation.
  • Issue: None — provides brief context, what is being changed, and reasonable why.
  • Recommendation: No update needed.

Impact of Change

  • No major format issues. All sections (Users, Developers, System) are filled in with clear descriptions of impact.
  • Recommendation: None required. If possible, elaborate on developer impacts (e.g., mention any migration steps/new abstraction details), but current description is sufficient.

Test Plan

  • Manual testing completed is checked. Unit and E2E not selected, but may be appropriate for a large refactor with expected visual/flow changes.
  • Recommendation: If applicable, add notes on unit/E2E coverage or future plans; as manual testing is reported, this is sufficient for passing.

⚠️ Contributors

  • No contributors tagged or mentioned, section is blank.
  • Recommendation: Tag any PMs, designers, or key team members who contributed if applicable, to provide team visibility and recognition.

Screenshots/Videos

  • Blank, which can pass. As this PR is highly visual/user interface focused, consider attaching a screenshot or screen recording to allow reviewers and designers to quickly verify the new experience.
  • Recommendation: Not required, but highly recommended given the user-facing nature of the change.

Summary Table

Section Status Recommendation
Title -
Commit Type -
Risk Level -
What & Why -
Impact of Change -
Test Plan Consider adding testing details if not manual only
Contributors ⚠️ Tag contributors for visibility
Screenshots/Videos Attach screenshots or video for visual changes

Please update the Contributors section if relevant and consider adding screenshots or a short video for clarity and designer/reviewer convenience. Otherwise, your PR is well-documented — great work keeping the description, risk analysis, and impact clear and specific!


Last updated: Fri, 17 Oct 2025 13:39:35 GMT

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive webview-based refactoring for creating Logic App workspaces and projects in the VS Code extension. The refactoring moves away from traditional command-line prompts to a modern React-based UI for better user experience and consistency.

Key Changes:

  • Replaces command-line wizards with React webviews for workspace and project creation
  • Adds support for multiple creation flows: standard workspace, workspace from package, workspace structure, and standalone Logic App projects
  • Implements comprehensive validation and path management through webview communication
  • Introduces Redux state management for workspace creation workflows

Reviewed Changes

Copilot reviewed 63 out of 63 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
libs/vscode-extension/src/lib/models/project.ts Adds new project types and context interfaces for webview-based creation
apps/vs-code-react/src/webviewCommunication.tsx Implements webview message handling for workspace creation flows
apps/vs-code-react/src/state/createWorkspace/createWorkspaceSlice.ts New Redux slice for managing workspace creation state
apps/vs-code-designer/src/app/commands/createWorkspace/createWorkspace.ts Refactored to use webview instead of command-line wizard
apps/vs-code-designer/src/app/commands/createNewCodeProject/ New comprehensive workspace and project creation implementation
apps/vs-code-designer/src/main.ts Adds workspace context management and project detection
Comments suppressed due to low confidence (1)

apps/vs-code-react/src/app/createWorkspace/steps/reviewCreateStep.tsx:1

  • Corrected grammar in success message text.
/*---------------------------------------------------------------------------------------------

Copy link

❌ PR Validation Error

An error occurred while validating your PR. Please try again later or contact the maintainers.

Error: Bad control character in string literal in JSON at position 1539

@ccastrotrejo ccastrotrejo added the Risk:High High risk change requiring careful review label Oct 16, 2025
Copy link

❌ PR Validation Error

An error occurred while validating your PR. Please try again later or contact the maintainers.

Error: Unexpected token '}', ..."!**\n---"
}" is not valid JSON

@lambrianmsft lambrianmsft changed the title DRAFT(vscode) - Webview Refactoring feat(vscode) - Webview Refactoring Oct 17, 2025
@lambrianmsft lambrianmsft changed the title feat(vscode) - Webview Refactoring feat(vscode) - Wizard to Webview Refactoring New Workspace, New Project, From Zip, and Converting Project To Workspace Oct 17, 2025
@lambrianmsft lambrianmsft changed the title feat(vscode) - Wizard to Webview Refactoring New Workspace, New Project, From Zip, and Converting Project To Workspace feat(vscode): Refactor wizard inputs to webview for workspace and project creation, zip import, and conversion Oct 17, 2025
@lambrianmsft lambrianmsft changed the title feat(vscode): Refactor wizard inputs to webview for workspace and project creation, zip import, and conversion feat(vscode): Refactor wizard inputs to webview for workspace creation Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated Risk:High High risk change requiring careful review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants