-
Notifications
You must be signed in to change notification settings - Fork 90
feat(vscode): Refactor wizard inputs to webview for workspace creation #8335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
Section | Status | Recommendation |
---|---|---|
Title | ✅ | - |
Commit Type | ✅ | - |
Risk Level | ✅ | - |
What & Why | ✅ | - |
Impact of Change | ✅ | - |
Test Plan | ✅ | Consider adding testing details if not manual only |
Contributors | Tag contributors for visibility | |
Screenshots/Videos | ✅ | Attach screenshots or video for visual changes |
Please update the Contributors section if relevant and consider adding screenshots or a short video for clarity and designer/reviewer convenience. Otherwise, your PR is well-documented — great work keeping the description, risk analysis, and impact clear and specific!
Last updated: Fri, 17 Oct 2025 13:39:35 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive webview-based refactoring for creating Logic App workspaces and projects in the VS Code extension. The refactoring moves away from traditional command-line prompts to a modern React-based UI for better user experience and consistency.
Key Changes:
- Replaces command-line wizards with React webviews for workspace and project creation
- Adds support for multiple creation flows: standard workspace, workspace from package, workspace structure, and standalone Logic App projects
- Implements comprehensive validation and path management through webview communication
- Introduces Redux state management for workspace creation workflows
Reviewed Changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
libs/vscode-extension/src/lib/models/project.ts | Adds new project types and context interfaces for webview-based creation |
apps/vs-code-react/src/webviewCommunication.tsx | Implements webview message handling for workspace creation flows |
apps/vs-code-react/src/state/createWorkspace/createWorkspaceSlice.ts | New Redux slice for managing workspace creation state |
apps/vs-code-designer/src/app/commands/createWorkspace/createWorkspace.ts | Refactored to use webview instead of command-line wizard |
apps/vs-code-designer/src/app/commands/createNewCodeProject/ | New comprehensive workspace and project creation implementation |
apps/vs-code-designer/src/main.ts | Adds workspace context management and project detection |
Comments suppressed due to low confidence (1)
apps/vs-code-react/src/app/createWorkspace/steps/reviewCreateStep.tsx:1
- Corrected grammar in success message text.
/*---------------------------------------------------------------------------------------------
apps/vs-code-react/src/app/createWorkspace/steps/workspaceNameStep.tsx
Outdated
Show resolved
Hide resolved
...signer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppVSCodeContents.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createWorkspace/createWorkspace.ts
Outdated
Show resolved
Hide resolved
...de-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/workspaceNameStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForLocalProject.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/createWorkspaceStyles.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/dotNetFrameworkStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/dotNetFrameworkStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/dotNetFrameworkStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createLogicApp/createWorkspaceStructSetupStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createLogicApp/createWorkspaceStructSetupStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createLogicApp/createLogicAppSetupStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/workflowTypeStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/workflowTypeStep.tsx
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/cloudToLocal/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/cloudToLocal/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/cloudToLocal/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
...ode-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateFunctionAppFiles.ts
Show resolved
Hide resolved
apps/vs-code-react/src/app/createWorkspace/steps/packageNameStep.tsx
Outdated
Show resolved
Hide resolved
… required field to labels to show that the field is required
…plates, pass in os separator
… and moved inside calling class
❌ PR Validation ErrorAn error occurred while validating your PR. Please try again later or contact the maintainers. Error: Bad control character in string literal in JSON at position 1539 |
❌ PR Validation ErrorAn error occurred while validating your PR. Please try again later or contact the maintainers. Error: Unexpected token '}', ..."!**\n---" |
Commit Type
Risk Level
What & Why
We are updating the create logic app workspace, create new project, create workspace from zip, and convert to project from using vscode wizards to a custom webview. This custom webview will give users one page to go over all the required fields instead of only seeing one field prompted at a time. This provides a simpler and more intuitive interface without making users remember what they have previously input. This change also updated underlying functionality to be more simple, which will help maintainability and to prevent users from encountering inconsistent behaviors with project or file creation.
Impact of Change
Test Plan
Contributors
Screenshots/Videos