-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] update control-plane-only user confirmation prompt #9404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @m-chau, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @m-chau
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the clarity of the warning message displayed during control-plane-only AKS upgrades by providing more detailed information about what will and won't be upgraded.
- Enhanced the user-facing message to explicitly clarify that only the Kubernetes version of the control plane is upgraded
- Added important information about node pool behavior: Kubernetes versions remain unchanged, but node image versions may still be upgraded if cluster config changes require VM reimage
| msg = ( | ||
| "Since control-plane-only argument is specified, this will upgrade only the control plane to " | ||
| f"{instance.kubernetes_version}. Node pool will not change. Continue?" | ||
| "Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to " |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two consecutive spaces after "to" in this line. It should be "control plane to {instance.kubernetes_version}" with only one space.
| "Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to " | |
| "Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to " |
|
please resolve merge conflict and fix failed CI checks |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
Please fix CI issues |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks upgradeGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.