[connectedk8s] Update Connectedk8s extension CLI to v1.10.12 #9416

atchutbarli · 2025-11-12T00:56:18Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

* forcedelete * format * add code owner * mypy

… '2025-08-01-preview' (#17)

…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove breaking change announcement for removed flags --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

azure-client-tools-bot-prd · 2025-11-12T00:56:21Z

❌Azure CLI Extensions Breaking Change Test

❌connectedk8s

rule cmd_name rule_message suggest_message

❌ 1007 - ParaRemove connectedk8s enable-features cmd connectedk8s enable-features removed parameter azrbac_client_id please add back parameter azrbac_client_id for cmd connectedk8s enable-features

❌ 1007 - ParaRemove connectedk8s enable-features cmd connectedk8s enable-features removed parameter azrbac_client_secret please add back parameter azrbac_client_secret for cmd connectedk8s enable-features

yonzhan · 2025-11-12T00:56:35Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-11-12T00:56:36Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2025-11-12T00:57:27Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

atchutbarli · 2025-11-12T00:58:05Z

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite.

github-actions · 2025-11-12T01:00:40Z

Hi @atchutbarli

⚠️ Release Requirements

Module: connectedk8s

⚠️ Please update VERSION to be 2.0.0 in src/connectedk8s/setup.py

Module: k8s-extension

Please log updates into to src/k8s-extension/HISTORY.rst
Update VERSION to 1.7.1 in src/k8s-extension/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull Request Overview

This PR updates the connectedk8s extension to version 1.10.12, introducing support for Azure Government Cloud (AGC) environments and removing deprecated RBAC parameters.

Adds endpoint overrides for AGC scenarios (ussec/usnat clouds) with cloud-specific configurations
Removes deprecated --app-id and --app-secret parameters from the enable-features command
Updates cluster diagnostics image to v1.31.2 for Pod Security standards compliance
Updates proxy image to v1.3.032281

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/connectedk8s/setup.py	Version bumped from 1.10.11 to 1.10.12
src/connectedk8s/HISTORY.rst	Added release notes for v1.10.12 with change summary
src/connectedk8s/azext_connectedk8s/_params.py	Removed deprecated azrbac_client_id and azrbac_client_secret parameter definitions
src/connectedk8s/azext_connectedk8s/custom.py	Removed deprecated parameters from enable_features function signature
src/connectedk8s/azext_connectedk8s/_utils.py	Added add_agc_endpoint_overrides function for AGC cloud support and helm install integration
src/connectedk8s/azext_connectedk8s/_constants.py	Updated cluster diagnostics image version to 1.31.2 and proxy version to 1.3.032281
src/connectedk8s/azext_connectedk8s/_breaking_change.py	Deleted file that registered deprecated argument warnings (cleanup after full removal)
src/k8s-extension/azext_k8s_extension/utils.py	Refactored get_mcr_path to accept endpoint string parameter instead of CLICommand
src/k8s-extension/azext_k8s_extension/custom.py	Updated get_mcr_path call to pass active_directory endpoint explicitly

src/connectedk8s/HISTORY.rst

src/connectedk8s/azext_connectedk8s/_utils.py

atchutbarli · 2025-11-13T18:34:55Z

@zhoxing-ms is the version upgrade to 2.00 required even when the breaking change is removing a switch on one of the command as in this PR?

zhoxing-ms · 2025-11-14T08:35:51Z

is the version upgrade to 2.00 required even when the breaking change is removing a switch on one of the command as in this PR?

@atchutbarli I think it depends on how big the impact of this breaking change is. If the impact is small, then upgrading the Minor version number is sufficient

Bavneet Singh and others added 18 commits September 30, 2025 09:40

add pester tests for connectedk8s cli extension

20aecd7

Pass the force delete param to the API call (#4)

40926a3

* forcedelete * format * add code owner * mypy

fix CI testcases for nodepool image issues (#8)

8f068a8

update python version to 3.13 (#12)

ad1ce1d

changes to support gateway association/disassociation for api version…

2121694

… '2025-08-01-preview' (#17)

Merge branch 'Azure:main' into main

ed5b5e2

remove hardcoded public ARM endpoint url for fairfax and mooncake (#24)

9038227

Bug Fix for FFX mcr url (#22)

002220d

[connectedk8s] update release notes and version (#26)

6c0a24b

Add Helm Overrides for AGC (#23)

3ca7ae1

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

update prediag version (#27)

979a4c3

Updating the proxy version constant (#28)

09119b8

Update relesae notes

a3efc72

Merge remote-tracking branch 'upstream/main' into release-v1.10.12

a80837e

dropping 3.9

7a60ee8

dropping testing folder

b15964e

Copilot AI review requested due to automatic review settings November 12, 2025 00:56

azure-client-tools-bot-prd bot added this to the December 2025 (2025-12-02) milestone Nov 12, 2025

Copilot started reviewing on behalf of atchutbarli November 12, 2025 00:57 View session

Copilot finished reviewing on behalf of atchutbarli November 12, 2025 00:59

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 12, 2025

Copilot AI reviewed Nov 12, 2025

View reviewed changes

src/connectedk8s/HISTORY.rst Outdated Show resolved Hide resolved

src/connectedk8s/azext_connectedk8s/_utils.py Show resolved Hide resolved

src/connectedk8s/azext_connectedk8s/_utils.py Outdated Show resolved Hide resolved

yonzhan requested a review from kairu-ms November 12, 2025 01:30

yonzhan assigned kairu-ms Nov 12, 2025

yonzhan requested review from yanzhudd and zhoxing-ms November 12, 2025 01:31

yonzhan assigned zhoxing-ms and unassigned kairu-ms Nov 12, 2025

yonzhan removed the request for review from kairu-ms November 12, 2025 01:32

fixed code review comments

04c61db

zhoxing-ms approved these changes Nov 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[connectedk8s] Update Connectedk8s extension CLI to v1.10.12 #9416

[connectedk8s] Update Connectedk8s extension CLI to v1.10.12 #9416

Uh oh!

atchutbarli commented Nov 12, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

yonzhan commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

atchutbarli commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atchutbarli commented Nov 13, 2025

Uh oh!

zhoxing-ms commented Nov 14, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

[connectedk8s] Update Connectedk8s extension CLI to v1.10.12 #9416

Are you sure you want to change the base?

[connectedk8s] Update Connectedk8s extension CLI to v1.10.12 #9416

Uh oh!

Conversation

atchutbarli commented Nov 12, 2025

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

CodeGen Tools Feedback Collection

Uh oh!

atchutbarli commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

⚠️ Release Requirements

Module: connectedk8s

Module: k8s-extension

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atchutbarli commented Nov 13, 2025

Uh oh!

zhoxing-ms commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

azure-client-tools-bot-prd bot commented Nov 12, 2025 •

edited

Loading

zhoxing-ms commented Nov 14, 2025 •

edited

Loading